[
https://issues.apache.org/jira/browse/THRIFT-906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Lavoie updated THRIFT-906:
------------------------------------
Attachment: v2-thrift-improved-haskell-bindings.patch
This is re-synced to current head, and NOT a superset of any other patch
(except it includes the import length from Prelude fix, since it's impossible
to compile code without it).
It also fixes a few uses of "fromInteger $ toInteger" in v1, and uses
fromIntegral instead.
> Improve type mappings
> ---------------------
>
> Key: THRIFT-906
> URL: https://issues.apache.org/jira/browse/THRIFT-906
> Project: Thrift
> Issue Type: New Feature
> Components: Haskell - Compiler, Haskell - Library
> Environment: Darwin -- 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr
> 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> The Glorious Glasgow Haskell Compilation System, version 6.12.3
> Reporter: Christian Lavoie
> Fix For: 0.5, 0.6, 0.7
>
> Attachments: thrift-improved-haskell-type-mappings.patch,
> v2-thrift-improved-haskell-bindings.patch
>
>
> The current haskell type mappings are awkward and error prone to work with:
> binary -> String
> string -> String
> byte -> Int
> i16 -> Int
> i32 -> Int
> i64 -> Int
> This patch updates the mappings to the canonical types of the correct length
> in Haskell:
> binary -> Data.ByteString.Lazy.ByteString
> string -> String
> byte -> Data.Word.Word8
> i16 -> Data.Int.Int16
> i32 -> Data.Int.Int32
> i64 -> Data.Int.Int64
> THIS BREAKS EXISTING CODE. It is, however, very arguably broken already.
> For convenience of patching, this patch is a superset of THRIFT-743.
> Thoughts?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
