[ 
https://issues.apache.org/jira/browse/THRIFT-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913627#action_12913627
 ] 

Christian Lavoie commented on THRIFT-743:
-----------------------------------------

Anthony -- I'm working on THRIFT-905 too, but my knowledge of autotools is... 
biased towards my mental stability, not towards deep expertise ;)

However, my v4 of THRIFT-743 is independent from any version of THRIFT-905, and 
should apply cleanly without.

To the best of my knowledge all versions of THRIFT-743 do NOT break previous 
versions of GHC; they merely rename a few identifiers away ( rec -> record, 
proc -> proc_ } because in 6.12 they became keywords under certain 
circumstances. This shouldn't have any negative effects on old ghc (no more 
than renaming a variable 'class' to 'klass' should break C compilers, but make 
it work in C++).

As far as which version of GHC to target, I'm aiming to have as few 
dependencies on modern GHC. Certainly my patches so far will relax the 
requirements on modern GHC; but I'm less sure about the required extra cabal 
packages. I spent a fair chunk of time yesterday trying to get an old ghc 
install working, but it's increasingly difficult to find a setup that satisfy 
all of the following criteria:

1) Compiles or runs from golden binaries

2) Has GHC <= 6.10

3) Has autotools >= 2.65

Typically, #2 and #3 are mutually exclusive (freebsd8.1, for example, only has 
autotools2.62; debian unstable won't compile ghc 6.10 with its packaged 6.12; 
debian stable has ghc 6.6 but downright ancient autotools; ...).

I would aim for this to compile cleanly on the last 2-3 haskell platform 
releases; it's fast becoming the haskell community's golden standard -- 
macports and fink haven't treated me well on mac on that regard, and are 
increasingly irrelevant for Haskell development, as far as I can tell.

> compile error with GHC 6.12.1
> -----------------------------
>
>                 Key: THRIFT-743
>                 URL: https://issues.apache.org/jira/browse/THRIFT-743
>             Project: Thrift
>          Issue Type: Bug
>          Components: Haskell - Compiler, Haskell - Library
>         Environment: Debian GNU/Linux 5.0.4, x86_64
>            Reporter: Martin Grabmueller
>            Assignee: Anthony Molinaro
>         Attachments: ghc-6.12.1-compile-problem-patch-v2.txt, 
> ghc-6.12.1-compile-problem-patch.txt, v3-thrift-compile-errors.patch, 
> v4-rename-proc-rec-keywords.patch
>
>
> The Haskell bindings do not compile with GHC 6.12.1, because rec seems to be 
> a reserved word in that version.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to