[
https://issues.apache.org/jira/browse/THRIFT-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914887#action_12914887
]
Ed Ceaser edited comment on THRIFT-917 at 9/25/10 6:40 PM:
-----------------------------------------------------------
yes you're right.
I think a reasonable behavior is, in the case of a RejectedExecutionException,
for a warning to get logged and the connection hung up on, with the intent that
the client should come back later.
I've got a patch that does that, and I'll add a test case for this situation to
make sure that its handled as gracefully as possible.
was (Author: ceaser):
yes you're right.
I think a reasonable behavior is, in the case of a RejectedExecutionException,
for a warning to get logged and the connection hung up on, with the intent that
the client should come back later.
> THsHaServer should not accept an ExecutorService without catching
> RejectedExecutionException
> --------------------------------------------------------------------------------------------
>
> Key: THRIFT-917
> URL: https://issues.apache.org/jira/browse/THRIFT-917
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
> Affects Versions: 0.5
> Reporter: Eric Jensen
> Assignee: Ed Ceaser
>
> https://issues.apache.org/jira/browse/THRIFT-250 introduced the ability to
> pass in an executor, but depending on the queue type your executor uses it
> can throw an unchecked RejectedExecutionException which it looks to me would
> kill the selector thread. we need to handle the general error behavior of an
> ExecutorService if we accept one as a parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
