[ 
https://issues.apache.org/jira/browse/THRIFT-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Lavoie updated THRIFT-932:
------------------------------------

    Attachment: v2-simplify-haskell-tests.patch

Same as v1, re-synced to HEAD. Apply with {{patch -p0 -E}}.

As it stands, it doesn't fix this bug, but it's self-contained and makes it 
much easier to run haskell tests. It's a great first step; next steps ought to 
be simple mucking around with autotools. Before:

# run/helper scripts don't give useful info when reporting 'user errors'
# Tests are split in two: Server, Client. The server needs to be started first, 
and is then left running after tests

After:

# Tests are combined/self-contained (each test is a process talking to itself 
through a TCP socket) that correctly exits after running
# There's a single run script
# run script has improved error messages
# run script defaults to the thrift binary compiled in the current source 
directory instead of those in PATH

> Haskell tests need to be run through 'make check' (and probably 'cabal 
> check') too
> ----------------------------------------------------------------------------------
>
>                 Key: THRIFT-932
>                 URL: https://issues.apache.org/jira/browse/THRIFT-932
>             Project: Thrift
>          Issue Type: Bug
>          Components: Haskell - Library
>    Affects Versions: 0.6
>         Environment: Mac OS X 10.6, latest haskell platform, ghc 6.12.3
> Darwin 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; 
> root:xnu-1504.7.4~1/RELEASE_I386 i386
> The Glorious Glasgow Haskell Compilation System, version 6.12.3
>            Reporter: Christian Lavoie
>            Assignee: Christian Lavoie
>             Fix For: 0.6
>
>         Attachments: out, v1-simplify-haskell-tests.hs, 
> v2-simplify-haskell-tests.patch
>
>
> Currently Haskell tests are run through an annoying pair of shell scripts, 
> and leave the server running after being executed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to