[
https://issues.apache.org/jira/browse/THRIFT-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919328#action_12919328
]
Esteve Fernandez commented on THRIFT-581:
-----------------------------------------
Hi Roger
> Hi Esteve, tests are important and that's why I had a look on this patch.
Cool! Thanks a lot for taking over this :-)
> now THRIFT-581_twisted-testsuite.v2.patch applies to revision 1005758 and
> from my perspective => ready to
> commit!
+1 Looks fine to me
Thanks!
> Add a testsuite for txThrift (Twisted)
> --------------------------------------
>
> Key: THRIFT-581
> URL: https://issues.apache.org/jira/browse/THRIFT-581
> Project: Thrift
> Issue Type: Test
> Components: Test Suite
> Reporter: Esteve Fernandez
> Assignee: Esteve Fernandez
> Priority: Critical
> Attachments: 581-twisted-testsuite.patch,
> THRIFT-581_twisted-testsuite.v2.patch
>
>
> Thrift lacks a testsuite for Twisted, this is unacceptable and should be
> addressed as soon as possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
