[
https://issues.apache.org/jira/browse/THRIFT-955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier updated THRIFT-955:
-------------------------------
Attachment: THRIFT-955_remove_CharLowerBuff.patch
Thanks Jeff!
I just removed that CharLowerBuff line and created the
patch[^THRIFT-955_remove_CharLowerBuff.patch] for revision
https://svn.apache.org/repos/asf/incubator/thrift/tags/0.5.0
The resulting compiler is here available:
http://people.apache.org/~roger/dist/thrift/0.5.0/w32-compiler-fix/
I generated several languages, e.g csharp with namespaces and corresponding
subfolders etc.
could you please verify?
I would really like to commit this to trunk.
> Thrift compiler for Windows uses lowercase names and directories which is
> inconsistent with compiling on other platforms
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-955
> URL: https://issues.apache.org/jira/browse/THRIFT-955
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Compiler
> Affects Versions: 0.5
> Environment: Windows 7 64 bit. Using thrift compiler for windows
> found at: http://incubator.apache.org/thrift/download/
> Reporter: Jeff Whiting
> Attachments: THRIFT-955_remove_CharLowerBuff.patch
>
>
> Using thrift compiler 0.5.0 for windows found at:
> http://incubator.apache.org/thrift/download/ the compiler produces lowercase
> files and paths rather than honoring the capitalization of the thrift file.
> However using the compiler on other platforms (I've tested OS X
> specifically), or an older compiler for windows found on the wiki, the name
> follows the capitalization of the thrift file.
> Windows compiler now compiling AdminService.thrift you get:
> ./gen-php/adminservice/adminservice_constants.php
> ./gen-php/adminservice/adminservice_types.php
> ./gen-php/adminservice/AdminService.php
> What you get on other OSes and what you used to get on older versions of
> windows compiler:
> ./gen-php/AdminService/AdminService_constants.php
> ./gen-php/AdminService/AdminService_types.php
> ./gen-php/AdminService/AdminService.php
> This is an inconsistency that can cause lots of headaches for developers when
> they are in a mixed environment using both windows and other OSes to compile
> thrift files. It makes it easy to get the wrong case and can cause problems
> for a case sensitive file system. It seems that the compiler should behave
> the same regardless of the platform.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
