[ https://issues.apache.org/jira/browse/THRIFT-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922162#action_12922162 ]
Richard Swift commented on THRIFT-591: -------------------------------------- Can someone from Facebook comment on Rush's last post? He raises some good questions about having two versions, unix-specific and ASIO-based, if the patch is approved and committed to the trunk. Would this work for the broader Thrift community? Is there any chance of moving Thrift onto a single multi-platofrm codebase? I think I may be able find some resources to help with the effort but need to know what the end result will look like before I ask. > Make the C++ runtime library be compatible with Windows and Visual Studio > ------------------------------------------------------------------------- > > Key: THRIFT-591 > URL: https://issues.apache.org/jira/browse/THRIFT-591 > Project: Thrift > Issue Type: New Feature > Components: C++ - Library > Environment: Windows XP and above, Visual Studio 2005 and above > Reporter: Rush Manbert > Attachments: MsvcPatchSupportScripts.zip, > MSVCSupportUpdatedButUntestedForThrift-0.4.0.patch, > THRIFT-591_MSVCSupportUpdatedButUntestedForThrift-0.4.0.patch_error.log, > thrift-818530-patched.zip, ThriftMsvcPatchForSvnRev818530.txt.zip, > thriftWindowsRev818530BugFix.zip > > > Modify the C++ runtime library to be compatible with Windows and able to be > built by Visual Studio. > The work has been done and a patch is available. I will attach it soon. > Note that this issue and the attached patch supercedes the patches that I > wrongly attached to JIRA 311. That issue is about making the C++ library > support async client/server interaction. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.