[
https://issues.apache.org/jira/browse/THRIFT-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922176#action_12922176
]
Bryan Duxbury commented on THRIFT-106:
--------------------------------------
{quote}
bq. The addition of getServerSocket to TServerSocket seems unnecessary, since
it's not used anywhere.
bq. I added it for 2 reasons, one is similarity to TSocket.getSocket and the
other if anyone want's to override TServerSocket, it would be nice to have the
underlying socket. Case in point we would require something like that for
Cassandra.
{quote}
OK, that's fine by me.
I think I'd prefer not to have those weak wrapper classes since they offer so
little functionality. It doesn't seem particularly useful to change the
semantics of isOpen(), so the rest is just an unnecessary class.
Glad to see you wrote a test :)
Just as a side note, it would be slightly more convenient for me if you
attached a combined patch instead of several in the future.
> TSSLServerSocket
> ----------------
>
> Key: THRIFT-106
> URL: https://issues.apache.org/jira/browse/THRIFT-106
> Project: Thrift
> Issue Type: New Feature
> Components: Java - Library
> Environment: n/a
> Reporter: rico sec
> Priority: Trivial
> Attachments: java-ssl.patch,
> Sample-keystore-for-tests-and-tutorial.patch, ssl.patch, TSSL-Testcase.patch,
> TSSLServerSocket-TSSLSocket-and-factory.patch,
> Updated-tutorial-with-ssl-sample.patch
>
> Original Estimate: 6h
> Remaining Estimate: 6h
>
> SSL Connection w/ autogenerated self signed x509 certs seems to be the state
> of the art for rpc layers.
> if thrift had one ...that would be very good.
> http://java.sun.com/javase/6/docs/technotes/guides/security/jsse/JSSERefGuide.html
> if someone does this pls ping/email me, I will do some testing and write a
> simple key mgmt utility.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
