If this is true, then maybe the default should be changed to --without-ruby?
-Anthony On Mon, May 03, 2010 at 03:48:50PM -0700, Kevin Clark wrote: > The non-gem version respected DESTDIR if I recall (that was the > mechanism I used to use to package it), but that was tossed when the > gem package (the defacto main distribution) became the only package. > We figured it didn't matter much - the only people not using gems tend > to be people repackaging into some other system (OS distro maintainers > and other one offs, though this included me at the time). Thrift may > want to make it clear in the README that it's now the only supported > way to install for Ruby. > > > On Mon, May 3, 2010 at 3:40 PM, Bryan Duxbury <[email protected]> wrote: > > You might call me the ruby maintainer. However, I don't think I'll be of > > much help with this one, since I only use the gem version of the ruby libs. > > > > On Mon, May 3, 2010 at 3:37 PM, Anthony Molinaro < > > [email protected]> wrote: > > > >> The ruby stuff also has the annnoying bit where it doesn't use destdir > >> with 'make install' which pretty much makes it impossible to package > >> thrift using traditional means. For the RPM and debs I build of thrift > >> I run with --without-ruby to work around this. It would be awesome if > >> whoever was the ruby maintainer were to figure out how to get it's install > >> target working with destdir... > >> > >> -Anthony > >> > >> On Mon, May 03, 2010 at 03:20:57PM -0700, Mark Slee wrote: > >> > This only appears to be in the lib/rb directory, though. I'm not seeing > >> any .o files in the C++ library or the compiler, for instance. > >> > > >> > mcs...@devrs001 /tmp/thrift/thrift-0.3.0 $find . -name "*.o" > >> > ./lib/rb/ext/binary_protocol_accelerated.o > >> > ./lib/rb/ext/compact_protocol.o > >> > ./lib/rb/ext/memory_buffer.o > >> > ./lib/rb/ext/protocol.o > >> > ./lib/rb/ext/struct.o > >> > ./lib/rb/ext/thrift_native.o > >> > > >> > I agree these shouldn't be distributed. The solution can be as simple as > >> manually removing them from the release for now until we get the make thing > >> properly patched. > >> > > >> > This issue aside, I'm a +1 on the rc1 candidate. It compiled without > >> issue for me (though again I have --with-ruby=no, so a ruby user should > >> confirm that stuff is working). > >> > > >> > -----Original Message----- > >> > From: Todd Lipcon [mailto:[email protected]] > >> > Sent: Saturday, May 01, 2010 8:12 PM > >> > To: [email protected] > >> > Subject: Re: Thrift 0.3.0 RC1 > >> > > >> > The tarball seems to include compiled .o files. > >> > > >> > I think the build process is just make dist, without the preceding make. > >> > > >> > -Todd > >> > > >> > On Sat, May 1, 2010 at 10:45 AM, Bryan Duxbury <[email protected]> > >> wrote: > >> > > >> > > I bootstrapped on my Mac. > >> > > > >> > > On Sat, May 1, 2010 at 9:09 AM, David Reiss <[email protected]> > >> wrote: > >> > > > >> > > > What system did you run bootstrap on? > >> > > > > >> > > > > >> > > > --David (mobile) > >> > > > > >> > > > On May 1, 2010, at 6:53 AM, "Bryan Duxbury" <[email protected]> > >> wrote: > >> > > > > >> > > > > Hi all, > >> > > > > > >> > > > > I'd like to propose the following tarball be accepted as the > >> > > > > official Thrift > >> > > > > 0.3.0 release: > >> > > > > > >> > > > > http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc1.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc1.tar.gz> > >> < > >> > > http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc1.tar.gz> > >> > > > <http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc1.tar.gz > >> > > > > > > >> > > > > > >> > > > > with GPG signature: > >> > > > > http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc1.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc1.tar.gz.asc> > >> < > >> > > http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc1.tar.gz.asc> > >> > > > < > >> http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc1.tar.gz.asc > >> > > > > > > >> > > > > and MD5 sum: 677607c0b5acb89fb35386169c7ffa8d > >> > > > > > >> > > > > This tarball was built by checking out > >> > > > > http://svn.apache.org/repos/asf/incubator/thrift/tags/0.3.0 and > >> > > > > running > >> > > > > "./boostrap.sh && ./configure && make && make dist". > >> > > > > > >> > > > > Please download, untar, configure, and build to verify that > >> > > > > everything works > >> > > > > as expected. Sorry about the false start. > >> > > > > > >> > > > > -Bryan > >> > > > > >> > > > >> > > >> > > >> > > >> > -- > >> > Todd Lipcon > >> > Software Engineer, Cloudera > >> > >> -- > >> ------------------------------------------------------------------------ > >> Anthony Molinaro <[email protected]> > >> > > > > > > -- > Kevin Clark > http://glu.ttono.us -- ------------------------------------------------------------------------ Anthony Molinaro <[email protected]>
