#5546: $model->deleteAll does not return boolean if callbacks is true --------------------------------------------+------------------------------- Reporter: shirsch | Owner: Type: Bug | Status: new Priority: Medium | Milestone: 1.2.x.x Component: Model | Version: RC3 Severity: Normal | Resolution: Keywords: deleteAll callbacks shirsch | Php_version: n/a Cake_version: | --------------------------------------------+------------------------------- Changes (by mark_story):
* keywords: deleteAll callbacks => deleteAll callbacks shirsch Old description: > Calling $model->deleteAll($condition, false, true) // callbacks = true > does not return a boolean return value. > > Solution starting in line 1666 in cake/libs/model.php: > > if ($callbacks) { > $_id = $this->id; > > $result = true; // new > foreach ($ids as $id) { > $result = ($result && $this->delete($id, $cascade)); // new > } > $this->id = $_id; > return $result; // new > } else { New description: Calling {{{$model->deleteAll($condition, false, true)}}} // callbacks = true does not return a boolean return value. [[BR]] Solution starting in line 1666 in cake/libs/model.php: {{{ #!php if ($callbacks) { $_id = $this->id; $result = true; // new foreach ($ids as $id) { $result = ($result && $this->delete($id, $cascade)); // new } $this->id = $_id; return $result; // new } else { }}} Comment: If you could provide a diff, that would be far more helpful. -- Ticket URL: <https://trac.cakephp.org/ticket/5546#comment:1> CakePHP : The Rapid Development Framework for PHP <https://trac.cakephp.org/> Cake is a rapid development framework for PHP which uses commonly known design patterns like ActiveRecord, Association Data Mapping, Front Controller and MVC. Our primary goal is to provide a structured framework that enables PHP users at all levels to rapidly develop robust web applications, without any loss to flexibility. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "tickets cakephp" group. To post to this group, send email to tickets-cakephp@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/tickets-cakephp?hl=en -~----------~----~----~----~------~----~------~--~---