#5553: $uses always merged from AppController
----------------------------------------------------+-----------------------
    Reporter:  NimaiMalle                           |          Type:  Bug       
      Status:  new                                  |      Priority:  Medium    
   Milestone:  1.2.x.x                              |     Component:  Controller
     Version:  RC3                                  |      Severity:  Normal    
    Keywords:  contorller AppController merge uses  |   Php_version:  n/a       
Cake_version:  1.2.0.7692 RC3                       |  
----------------------------------------------------+-----------------------
 Inside of `cake/libs/controller/controller.php` in the `_mergeVars`
 function, there is the following snippet of code:

 {{{
         if ($uses == $this->uses && !empty($this->uses)) {
 ...
         } elseif ($this->uses !== null || $this->uses !== false) {
                 $merge[] = 'uses';
         }
 }}}

 The condition in the `elseif` will always resolve to `true`.
 I believe what was intended was an `&&` operator.

 {{{
         } elseif ($this->uses !== null && $this->uses !== false) {
 }}}

 With this change, controllers can declare `$uses` as `null` or `false`,
 and they won't get `$uses` from `AppController` forced upon them.
 [[BR]]
 [[BR]]
 (I am using 1.2.0.6311 beta, but this code is still unchanged in RC3, so
 that's the version I put in the Ticket Properties below.)

-- 
Ticket URL: <https://trac.cakephp.org/ticket/5553>
CakePHP : The Rapid Development Framework for PHP <https://trac.cakephp.org/>
Cake is a rapid development framework for PHP which uses commonly known design 
patterns like ActiveRecord, Association Data Mapping, Front Controller and MVC. 
Our primary goal is to provide a structured framework that enables PHP users at 
all levels to rapidly develop robust web applications, without any loss to 
flexibility.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"tickets cakephp" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/tickets-cakephp?hl=en
-~----------~----~----~----~------~----~------~--~---

  • [CakePHP : The Rapid Dev... CakePHP : The Rapid Development Framework for PHP

Reply via email to