#5792: Inflector optimization by returning replaced values instead of assining
before returning
----------------------------------------------+-----------------------------
Reporter: kiger | Type: Bug
Status: new | Priority: Low
Milestone: 1.2.x.x | Component: Core Libs
Version: RC3 | Severity: Normal
Keywords: inflector underscore optimize | Php_version: n/a
Cake_version: 7883 |
----------------------------------------------+-----------------------------
Inflector::underscore() is called 600+ times in a normal page load on my
site. Currently it takes 12ms for all 600+ calls. There is an easy way to
shave off 3ms by simply returning the replaced value instead of assigning
it and then returning the assigned value.[[BR]]
[[BR]]
Simply change this:
{{{
function underscore($camelCasedWord) {
$replace = strtolower(preg_replace('/(?<=\\w)([A-Z])/', '_\\1',
$camelCasedWord));
return $replace;
}
}}}
[[BR]]
To this:
{{{
function underscore($camelCasedWord) {
return $replace = strtolower(preg_replace('/(?<=\\w)([A-Z])/',
'_\\1', $camelCasedWord));
}
}}}
[[BR]]
This can also be done for the other 1 line methods in inflector.
--
Ticket URL: <https://trac.cakephp.org/ticket/5792>
CakePHP : The Rapid Development Framework for PHP <https://trac.cakephp.org/>
Cake is a rapid development framework for PHP which uses commonly known design
patterns like ActiveRecord, Association Data Mapping, Front Controller and MVC.
Our primary goal is to provide a structured framework that enables PHP users at
all levels to rapidly develop robust web applications, without any loss to
flexibility.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"tickets cakephp" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/tickets-cakephp?hl=en
-~----------~----~----~----~------~----~------~--~---