#5902: [PATCH] remove uneeded DS on CakeTest::_loadFixtures() when loading core
fixtures
--------------------------------+-------------------------------------------
Reporter: rafaelbandeira3 | Type: Optimization
Status: new | Priority: Very Low
Milestone: 1.2.x.x | Component: Test Suite
Version: RC3 | Severity: Trivial
Keywords: | Php_version: n/a
Cake_version: |
--------------------------------+-------------------------------------------
in CAKE/libs/configure.php, Configure::corePaths, line 507 to 517 :
{{{
$cake = $path . DS . 'cake' . DS;
$libs = $cake . 'libs' . DS;
if (is_dir($libs)) {
$paths['libs'][] = $libs;
$paths['model'][] = $libs . 'model' . DS;
$paths['behavior'][] = $libs . 'model' . DS . 'behaviors' . DS;
$paths['controller'][] = $libs . 'controller' . DS;
$paths['component'][] = $libs . 'controller' . DS . 'components' .
DS;
$paths['view'][] = $libs . 'view' . DS;
$paths['helper'][] = $libs . 'view' . DS . 'helpers' . DS;
$paths['cake'][] = $cake;
}}}
as we can see, $cake already has a trailing DS, therefore
Configure::corePaths('cake') will return a path with a trailing DS, so
there's no need for the concatenated DS after the $path var, which only
produces an extra DS that will be ignored
{{{
$fixturePaths[] = $path . DS . 'tests' . DS . 'fixtures';
}}}
patch added
--
Ticket URL: <https://trac.cakephp.org/ticket/5902>
CakePHP : The Rapid Development Framework for PHP <https://trac.cakephp.org/>
Cake is a rapid development framework for PHP which uses commonly known design
patterns like ActiveRecord, Association Data Mapping, Front Controller and MVC.
Our primary goal is to provide a structured framework that enables PHP users at
all levels to rapidly develop robust web applications, without any loss to
flexibility.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"tickets cakephp" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/tickets-cakephp?hl=en
-~----------~----~----~----~------~----~------~--~---
