#752: should not use "substr($str, 0, 1)" but "$str[0]"
-------------------------+--------------------------------------------------
Reporter: MugeSo | Owner: david
Type: enhancement | Status: closed
Priority: normal | Milestone: 0.11.2
Component: _OTHER_ | Version: 0.11.0
Severity: normal | Resolution: wontfix
Keywords: | Has_patch: 0
-------------------------+--------------------------------------------------
Changes (by david):
* status: assigned => closed
* resolution: => wontfix
Comment:
I thought about this... the problem is that we'd get a notice if the
string is empty. So we have to add a {{{strlen()}}} check, too. Which
means we again have a method call, which probably eliminates the
performance advantage, and most importantly: makes the code less readable.
Not worth it in the end, I think. I'm closing this as ''wontfix'' for now;
feel free to re-open the ticket if you believe I'm wrong, or add comments,
or discuss it on IRC/dev mailing list :)
--
Ticket URL: <http://trac.agavi.org/ticket/752#comment:3>
Agavi <http://www.agavi.org/>
An MVC Framework for PHP5
_______________________________________________
Agavi Tickets Mailing List
[email protected]
http://lists.agavi.org/mailman/listinfo/tickets
