#917: Always merge slot response metadata even if response content is null
--------------------+-------------------------------------------------------
Reporter: david | Owner: david
Type: task | Status: new
Priority: normal | Milestone: 0.11.6
Component: filter | Version: 0.11.5
Severity: minor | Keywords:
Has_patch: 0 |
--------------------+-------------------------------------------------------
It's not possible for instance for a slot to just set a cookie or a
redirect. A {{{return '';}}} needs to be made at least. That's not good.
I don't remember what the check there is for:
{{{
if(($output[$slotName] = $slotResponse->getContent()) !== null) {
$response->merge($slotResponse);
}
}}}
but it was likely optimization.
I doubt anyone is setting a redirect or response *before* checking if that
is allowed at all, and then uses {{{return}}} to bail out and prevent
things from happening. Even if, those people can fix their code to make
sense, or use {{{$response->clear();}}} in worst case. It's almost a bug
fix this, and warrants the slight, but unlikely change in behavior.
--
Ticket URL: <http://trac.agavi.org/ticket/917>
Agavi <http://www.agavi.org/>
An MVC Framework for PHP5
_______________________________________________
Agavi Tickets Mailing List
[email protected]
http://lists.agavi.org/mailman/listinfo/tickets
