#955: AgaviWebRequestDataHolder method implementations are all over the place
---------------------+------------------------------------------------------
Reporter: david | Owner: david
Type: defect | Status: assigned
Priority: normal | Milestone: 0.11.6
Component: request | Version: 0.11.5
Severity: major | Keywords:
Has_patch: 0 |
---------------------+------------------------------------------------------
Changes (by david):
* status: new => assigned
Old description:
> * {{{isParameterValueEmpty()}}} returns {{{false}}} for a
> {{{null}}} value ever since [2291]/#693
> * none of the {{{get()}}} and {{{has()}}} implementations were updated
> to handle null values in the same way as [2291]/#693
> * {{{removeCookie()}}} doesn't support array syntax
> * {{{getFile()}}}/{{{hasFile()}}}/{{{removeFile()}}} don't perform a
> literal lookup first
> * {{{removeFile()}}} contains old code from the days before the
> introduction of {{{AgaviUplodadedFile}}} in [[1530]] (a.k.a. dinosaur's
> age)
> In general, it would probably be smart to simply create
> {{{AgaviParameterHolder}}} instances for each source, and just proxy the
> calls, but I'll leave that for another ticket.
New description:
* {{{isParameterValueEmpty()}}} returns {{{false}}} for a {{{null}}} value
ever since [2291]/#693
* none of the {{{get()}}} and {{{has()}}} implementations were updated to
handle null values in the same way as [2291]/#693
* {{{removeCookie()}}} doesn't support array syntax
* {{{getFile()}}}/{{{hasFile()}}}/{{{removeFile()}}} don't perform a
literal lookup first
* {{{removeFile()}}} contains old code from the days before the
introduction of {{{AgaviUplodadedFile}}} in [1530] (a.k.a. dinosaur's age)
In general, it would probably be smart to simply create
{{{AgaviParameterHolder}}} instances for each source, and just proxy the
calls, but I'll leave that for another ticket.
--
--
Ticket URL: <http://trac.agavi.org/ticket/955#comment:1>
Agavi <http://www.agavi.org/>
An MVC Framework for PHP5
_______________________________________________
Agavi Tickets Mailing List
[email protected]
http://lists.agavi.org/mailman/listinfo/tickets
