#452: Get rid of array_unshift whereever possible
-------------------------+--------------------------------------------------
Reporter: david | Owner: david
Type: task | Status: closed
Priority: high | Milestone: 1.0
Component: _OTHER_ | Version:
Severity: trivial | Resolution: wontfix
Keywords: performance | Has_patch: 0
-------------------------+--------------------------------------------------
Changes (by impl):
* status: new => closed
* has_patch: => 0
* resolution: => wontfix
Comment:
Resolving this as wontfix as there are a total of 4 instances of
array_unshift in the Agavi source code; one is in a config handler
(therefore it doesn't matter in production mode anyway), two are in code
that handles fixing $_FILES (used rarely, basically), and one is in
handling array paths for validation purposes. Profiling reveals that
array_unshift is still faster than about 90% of the other code called by
those functions, so this bug is pretty much just total nonsense.
--
Ticket URL: <http://trac.agavi.org/ticket/452#comment:2>
Agavi <http://www.agavi.org/>
An MVC Framework for PHP5
_______________________________________________
Agavi Tickets Mailing List
[email protected]
http://lists.agavi.org/mailman/listinfo/tickets
