#1113: Testing Framework Limitations
---------------------+------------------------------------------------------
 Reporter:  jake     |        Owner:  felix  
     Type:  defect   |       Status:  closed 
 Priority:  high     |    Milestone:         
Component:  testing  |      Version:  1.0.1  
 Severity:  normal   |   Resolution:  invalid
 Keywords:           |    Has_patch:  0      
---------------------+------------------------------------------------------
Changes (by felix):

  * status:  assigned => closed
  * resolution:  => invalid


Comment:

 Hi Jake,

 I haven't tested all assertions but the ones I tested work perfectly fine.
 I think the main problem is a misconception on how the viewtest works: The
 view-test assertions only test the view itself. So the assertion
 "assertResponseHasHeader" actually tests that the view under test sets the
 given response header. There's more ways to set headers in agavi (output
 type etc..) that are not taken into account by this assertion - that would
 be a flowtest.

 I see that the assertions are named a bit misleading, so I'll close this
 ticket and create a new one stating that we should rename these
 asssertions to a better name - maybe something along the lines of
 "assertViewSetsHeader(foo)" which would make the scope of the assertion
 clearer.

 I hope that clears it up for the moment.

 felix

-- 
Ticket URL: <http://trac.agavi.org/ticket/1113#comment:4>
Agavi <http://www.agavi.org/>
An MVC Framework for PHP5


_______________________________________________
Agavi Tickets Mailing List
[email protected]
http://lists.agavi.org/mailman/listinfo/tickets

Reply via email to