#1201: Move error suppression operator for XML validation calls to wrapper
methods
--------------------+-------------------------------------------------------
Reporter: david | Owner: impl
Type: task | Status: new
Priority: low | Milestone: 1.0.2
Component: config | Version: 1.0.1
Severity: minor | Keywords:
Has_patch: 0 |
--------------------+-------------------------------------------------------
For example, in
[source:tags/1.0.1/src/config/AgaviXmlConfigParser.class.php#L814
AgaviXmlConfigParser::validateXmlschema()], the {...@}}} error suppression
operator is used to prevent a warning from
{{{DOMDocument::schemaValidate()}}} in case the schema file is invalid or
unreadable:
{{{
@$document->schemaValidate($validationFile);
}}}
However, the actual method being called here is
[source:tags/1.0.1/src/config/util/dom/AgaviXmlConfigDomDocument.class.php#L286
AgaviXmlConfigDomDocument::schemaValidate()], which is a wrapper with some
error handling features.
Obviously, the {...@}}} operator should be used there, not in the calling
code.
Same applies of course to the other validation methods.
--
Ticket URL: <http://trac.agavi.org/ticket/1201>
Agavi <http://www.agavi.org/>
An MVC Framework for PHP5
_______________________________________________
Agavi Tickets Mailing List
[email protected]
http://lists.agavi.org/mailman/listinfo/tickets
