#1205: Allow protected executeVIEWNAME base methods: executeView should use
"is_callable" rather than "method_exists"
--------------------------------------+-------------------------------------
 Reporter:  michalchare...@…          |       Owner:  david      
     Type:  enhancement               |      Status:  new        
 Priority:  low                       |   Milestone:  1.0.2      
Component:  view                      |     Version:  1.0.1      
 Severity:  minor                     |    Keywords:  view filter
Has_patch:  0                         |  
--------------------------------------+-------------------------------------
 I suspect line 739 of AgaviExecutionFilter.class.php should use
 "is_callable" rather than "method_exists" to check if a view implements an
 output type.

 This is so a base view class can implement "default" operations for an
 output type in a protected method. Then if a view wants to implement this
 output type, it can override this using a public method that just calls
 its protected parent function.

 (method_exists returns true for all functions, even protected ones that
 are not callable from the current scope, so cannot be used to distinguish
 between protected and public methods)

-- 
Ticket URL: <http://trac.agavi.org/ticket/1205>
Agavi <http://www.agavi.org/>
An MVC Framework for PHP5



_______________________________________________
Agavi Tickets Mailing List
[email protected]
http://lists.agavi.org/mailman/listinfo/tickets

Reply via email to