#1221: AgaviLoggerAppender::write() lacks type hint
---------------------+------------------------------------------------------
Reporter: felix | Owner: david
Type: defect | Status: assigned
Priority: normal | Milestone: 1.0.3
Component: logging | Version: 1.0.2
Severity: normal | Keywords:
Has_patch: 0 |
---------------------+------------------------------------------------------
Changes (by david):
* status: new => assigned
Old description:
> Some parts of the logging code are documented as accepting strings (for
> example AgaviLoggerAppender::write()) while other parts expect the
> message to be an AgaviLoggerMessage object (AgaviPassthruLoggerLayout,
> AgaviTimestampLoggerLayout). Feeding a string to
> AgaviLoggerAppender::write() will actually cause a crash.
>
> We should fix the code comments and the type hinting accordingly.
New description:
Expects an {{{AgaviLoggerMessage}}}, but is documented to accept a string
or mixed value.
--
--
Ticket URL: <http://trac.agavi.org/ticket/1221#comment:1>
Agavi <http://www.agavi.org/>
An MVC Framework for PHP5
_______________________________________________
Agavi Tickets Mailing List
[email protected]
http://lists.agavi.org/mailman/listinfo/tickets
