#1282: Add line numbers to FPF parse error response
------------------------------------------------------------------+---------
 Reporter:  a.fied...@…                                           |        
Owner:  david  
     Type:  enhancement                                           |       
Status:  closed 
 Priority:  normal                                                |    
Milestone:  1.0.4  
Component:  filter                                                |      
Version:  1.0.3  
 Severity:  normal                                                |   
Resolution:  wontfix
 Keywords:  FormPopulationFilter FPF error reporting line number  |    
Has_patch:  1      
------------------------------------------------------------------+---------
Changes (by david):

  * status:  new => closed
  * resolution:  => wontfix


Comment:

 The purpose of this patch is to output the document as it was parsed by
 FPF, right? The code you posted (you can wrap it in {{{{{{}}} and
 {{{}}}}}} to format it as code, or better, attach patches to tickets or
 pastie them if possible) somehow seems to assume that content starts on
 Line 2 (why?), and uses {{{preg_replace}}} "e" modifier, which is bad for
 several reasons (e.g. not available with Suhosin).

 FPF can already do this already. Enable logging, and it will log the
 messages along with the full response content. That's also much more
 readable than on this exception page, with all the indent etc. See #543.

-- 
Ticket URL: <http://trac.agavi.org/ticket/1282#comment:1>
Agavi <http://www.agavi.org/>
An MVC Framework for PHP5



_______________________________________________
Agavi Tickets Mailing List
[email protected]
http://lists.agavi.org/mailman/listinfo/tickets

Reply via email to