#1287: Remove call overload and ArrayObject usage from AgaviUploadedFile
---------------------+------------------------------------------------------
Reporter: david | Owner: david
Type: task | Status: new
Priority: low | Milestone: 1.1
Component: request | Version:
Severity: minor | Keywords:
Has_patch: 0 |
---------------------+------------------------------------------------------
Comment(by david):
There are several problems with this patch:
1. why does it use {{{$this->data}}}? Either use
{{{AgaviParameterHolder}}}, or simply use the properties directly (that
would be the better choice, in my opinion)
2. if it implements {{{ArrayAccess}}}, then why are you replacing
{{{$this->tmp_name}}} with {{{$this->data['tmp_name']}}} and so forth?
3. It doesn't follow the coding standards (e.g. {{{if (…)}}} instead of
{{{if(…)}}})
--
Ticket URL: <http://trac.agavi.org/ticket/1287#comment:3>
Agavi <http://www.agavi.org/>
An MVC Framework for PHP5
_______________________________________________
Agavi Tickets Mailing List
[email protected]
http://lists.agavi.org/mailman/listinfo/tickets
