All, I'm looking for some clarification around the Enterprise Profile identifier TLV defined in the draft. In particular - how it maps onto the ORGANIZATION_EXTENSION TLV as per IEEE 1588. The TLV as a whole new TLV is fine, however it uses an existing TLV, so it should conform.
1588: tlvType 2 octets, lengthField 2 octets, oui 3 octets, orgSubType 3 octets, dataField N octets. Enterprise Profile - all matches up to OUI. Then we have: Profile number: 1 octet, Revision Number: 1 octet, Port Number: 2 octets, MaxPhaseAdj: 2 octets My question is: how do the 2 octets of profile number and revision number align with the 3-octet SubType field? If they do not, then this TLV does not meet the 14.3.2 spec. If they do, then the draft should clearly specify how the profile/revision map onto the SubType field. The org-specific structure begins with the dataField, not orgSubType - unless the intention is to use the "shall" escape in 14.3.2.5. My suggestion would be that either: - some fixed "TICTOC" ID is placed into the SubType, and all other fields are in the DataField, and that is clearly defined in the profile RFC, - a mapping of profile/revision to orgSubType is provided by the RFC, and a statement that portNumber and maxPhaseAdj are mapped onto the DataField. Any comments welcome, and apologies if this has already been discussed. Regards, Wojciech -- - Wojciech Owczarek
_______________________________________________ TICTOC mailing list [email protected] https://www.ietf.org/mailman/listinfo/tictoc
