One more comment with the structure of the YANG Module: The data model specified used several "enum" type, making it very difficult to expand in the future.
For example, "delay-mechanism-enumeration" currently has "e2e", "p2P", and "disabled". If you want to add one more value, the new data model is not backward compatible. Should consider using "identity" and use "identityref". When expand in the future, data model is still backward compatible. Linda Dunbar -----Original Message----- From: Gen-art [mailto:[email protected]] On Behalf Of Linda Dunbar Sent: Tuesday, September 04, 2018 5:30 PM To: [email protected] Cc: [email protected]; [email protected]; [email protected] Subject: [Gen-art] Genart last call review of draft-ietf-tictoc-1588v2-yang-09 Reviewer: Linda Dunbar Review result: Almost Ready I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. Document: draft-ietf-tictoc-1588v2-yang-?? Reviewer: Linda Dunbar Review Date: 2018-09-04 IETF LC End Date: 2018-09-07 IESG Telechat date: Not scheduled for a telechat Summary: This document specify the YANG data model for IEEE1588-2008. The document is written very clear. I have some questions, such as What is the relationship between Current-DS and Default-DS? It seems to be that the "default-ds" has most of the information for the clock. Is Current-ds simply supplement? Major issues: Minor issues: Nits/editorial comments: _______________________________________________ Gen-art mailing list [email protected] https://www.ietf.org/mailman/listinfo/gen-art _______________________________________________ TICTOC mailing list [email protected] https://www.ietf.org/mailman/listinfo/tictoc
