Hi,
I have no chance to tryout the stuff on IE8 but I assume the following
change (to the code block given above) should fix the issue:
var txt = createTiddlyElement(null,"input",null,null,null);
if(params[0])
txt.value = params[0];
txt.onkeyup = keyHandler;
txt.onfocus = focusHandler;
txt.setAttribute("size",sizeTextbox);
txt.setAttribute("accessKey",this.accessKey);
txt.setAttribute("autocomplete","off");
if(config.browser.isSafari)
{
txt.setAttribute("type","search");
txt.setAttribute("results","5");
}
else
txt.setAttribute("type","text");
if(place)
place.appendChild(txt);
(i.e. pass "null" as the createTiddlyElement parent and add the newly
create element to the DOM tree after it is fully created)
It would be nice if some IE8 user could verify if this fixes the
issue. I will then release a new revision of the YourSearchPlugin
soon.
Udo
If somebody could
On 29 Aug., 21:17, Tobias <[email protected]> wrote:
> Good job,
>
> I hope Udo will read this and have a look at it.
>
> Tobias.
>
> On 29 Aug., 19:49, rouilj <[email protected]> wrote:
>
> > On Jul 30, 11:55 pm, rouilj <[email protected]> wrote:
>
> > > Hello all:
> > > I am using IE 8 with:
>
> > > http://tiddlywiki.abego-software.de/#YourSearchPluginversion2.1.3
> > > (2008-04-16) under TW 2.5.2
>
> > > and when I load the TW I see the following error when I click on the
> > > red error box under the search box in the sidebar:
>
> > > Error while executing macro <<search>>
> > > Error: this command is not supported
>
> > It looks like this bit of code is the problem:
>
> > var txt = createTiddlyElement(place,"input",null,null,null);
> > if(params[0])
> > txt.value = params[0];
> > txt.onkeyup = keyHandler;
> > txt.onfocus = focusHandler;
> > txt.setAttribute("size",sizeTextbox);
> > txt.setAttribute("accessKey",this.accessKey);
> > txt.setAttribute("autocomplete","off");
> > if(config.browser.isSafari)
> > {
> > txt.setAttribute("type","search");
> > txt.setAttribute("results","5");
> > }
> > else
> > ;//txt.setAttribute("type","text");
>
> > specifically the last commented out line. According
> > tohttps://connect.microsoft.com/IE/feedback/ViewFeedback.aspx?FeedbackI...
> > you can't change the type of an element after it has been rendered
> > into the DOM. Commenting out that line as shown above stops
> > the macro error, but it is obviously not a solution.
>
> > Does Udo or anybody from Abego software read this group? I have a
> > feeling this will need their efforts to fix. I will also
> > drop the author an email pointing to this thread.
>
> > -- rouilj
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"TiddlyWiki" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/tiddlywiki?hl=en
-~----------~----~----~----~------~----~------~--~---
