Dear all,

*About the "jump to next/previous match" feature*: Sorry, it takes some 
more time to do: *basically I'm done, but it has compatibility issues* and 
I don't like to release until everything works.

Javascript developers, please help: I tested the current version (demo is 
here 
<https://bimlas.gitlab.io/demo/tw5/highlight-searched-text-compatibility-issue.html>,
 
*do not use it in real wikis, work in progress*, etc.) on an old browser 
which is my phone's default (Samsung Browser 3.3 on Android), thus I think 
it may be an issue for others too.

Whenever I want to jump between results, it always jumps to the first or 
last result (just the opposite end of the search direction).

I am sure this is a problem with the code of the action-widget 
<https://bimlas.gitlab.io/demo/tw5/highlight-searched-text-compatibility-issue.html#%24%3A%2Fplugins%2Fbimlas%2Fhighlight-searched-text%2Faction-scroll-to-match.js>,
 
or that the value of window.outerHeight (the height of the visible area) is 
incorrect in my browser (I also tried to query with window.innerHeight) or 
the value of this.previousMatch may not be stored.

Anyone familiar with Javascript (and specifically TiddlyWiki) programming 
could look at which instruction is incompatible with old browsers? You may 
have found a clear mistake in it that did not occur to me.

My other request would be to give it a try and play with it for a while to 
find out more errors.

Please write your suggestions at 
https://github.com/bimlas/tw5-highlight-searched-text/issues/1 or 
contribute directly to the code by forking https://*gitlab*
.com/bimlas/tw5-highlight-searched-text/tree/find-in-page 
<https://gitlab.com/bimlas/tw5-highlight-searched-text/tree/find-in-page>

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywiki/4092e495-8195-4217-a062-4ab185b74195%40googlegroups.com.

Reply via email to