Hi, 

Your manifest contains a content_security_policy": 'unsafe-eval' ... Why? 
IMO there is no need to execute unsafe code.
Can you please explain! 

The variables in the code itself seem to be shortened, which makes reading 
the code very hard. Are you sure, it will pass the AMO code guidelines 
<https://extensionworkshop.com/documentation/publish/add-on-policies/#submission-guidelines>
.


Your background.js code contains this header: 

/* this is some particularly spicy garbage. tl;dr we can't await anything 
> in the
> user input handler if we hope to call openPopup(), which is rather crucial 
> to the whole “conditional popup” “quick mode” *thing*. so, instead of 
> accessing the appropriate storage in the input handler, we close over these 
> globals in the storage update handlers for local.state and sync.quickmode. 
> we fire off some fake updates to the values to make sure those closures 
> run, 
> then in the input handler we use these globals and pretend we've accessed 
> storage. 
>
> with any luck once this addon is stable i will never write another line of 
> this hideous language as long as i live */


Why do you think, this makes users feel safe using your add on. 

regards
-mario


-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywiki+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywiki/fb6553da-cfca-4b34-bb73-6c271b33dce4%40googlegroups.com.

Reply via email to