Hi Mark, Firstly apologies for the trial and error approach at debugging yesterday. I was trying to help but didn't have access to my dev machine.
I've done some debugging and have confirmed that as you suspected, there is a bug where only new tiddlers with multiline fields are saved as .json This bug is the same underlying issue as the PR we have been discussing but that PR only addresses it for situations where $:/config/SystemFileExtensions or $:/config/FileSystemPaths has been set. I'll investigate next if there is an easy fix/patch you can run in the interim. Regards, Saq On Friday, July 17, 2020 at 11:45:19 PM UTC+2, Mark S. wrote: > > Hi Saq, > > I don't think it's possible to test for multiple lines in a single filter. > > For the purposes of my experiments, I set a field by hand on the tiddlers > with multiple lines and then set this per your example in > $:/config/SystemFileExtensions: > > [has[ismulti]then[.json]] > > But that didn't do anything (even after saving, stopping, restarting, and > reloading). It continued to produce tid files with the broken format. > > Thanks! > > On Friday, July 17, 2020 at 12:02:43 PM UTC-7, Saq Imtiaz wrote: >> >> @Mark as a temporary fix try this: >> >> With the patch files in place, create $:/config/SystemFileExtensions >> where the text is a filter like >> >> [has[multiline]then[.json]] >> >> >> Edit: replace multiline with some other criteria to identify tiddlers >> with mutiline fields >> >> On Friday, July 17, 2020 at 8:57:48 PM UTC+2, Saq Imtiaz wrote: >>> >>> @Mark I suspect it may be the case that it is the same underlying issue, >>> but the PR only fixes it in the situation where $:/config/FileSystemPaths >>> is being used. >>> >>> On Friday, July 17, 2020 at 8:34:45 PM UTC+2, Saq Imtiaz wrote: >>>> >>>> The PR addresses an issue where the filepath and extension for a >>>> tiddler wont change after its been created. So it is my suspicion that is >>>> why the tiddler doesnt get switched from a .tid file to a .json file when >>>> we add a multiline field. >>>> >>>> It is possible there has been a regression elsewhere that is causing >>>> your issue. I can attempt to take a closer look tomorrow if this is still >>>> unresolved at that time. >>>> >>>> On Friday, July 17, 2020 at 8:07:43 PM UTC+2, Mark S. wrote: >>>>> >>>>> Yes, that's SOP. It's unclear to me that the problem addressed in the >>>>> PR is the same problem I'm experiencing. >>>>> >>>>> Thanks! >>>>> >>>>> On Friday, July 17, 2020 at 10:54:36 AM UTC-7, Saq Imtiaz wrote: >>>>>> >>>>>> Mark: did you restart the server after adding the two files, and then >>>>>> also reload the wiki in the browser? >>>>>> >>>>>> >>>>>> On Friday, July 17, 2020 at 7:40:49 PM UTC+2, Mark S. wrote: >>>>>>> >>>>>>> >>>>>>>> You could also merge that patch in a local copy of the repo and run >>>>>>>> that until it is officially merged. >>>>>>>> https://github.com/Jermolene/TiddlyWiki5/pull/4630 >>>>>>>> <https://www.google.com/url?q=https%3A%2F%2Fgithub.com%2FJermolene%2FTiddlyWiki5%2Fpull%2F4630&sa=D&sntz=1&usg=AFQjCNGrfHQT2VZzroheMKRZYs-2aOqt-w> >>>>>>>> >>>>>>> >>>>>>> Is there any sane, easy way to navigate in GH and get just the two >>>>>>> files? >>>>>>> >>>>>>> GH is so opaque. I can see a commit on the files in the branch was >>>>>>> made only a few days ago. But when I try to view (and then download) >>>>>>> the >>>>>>> files, it says the latest commit was 22 days ago. Huh? >>>>>>> >>>>>>> So I tried to download the two files. Added them to the tiddlers dir >>>>>>> as ext .js. Checking the shadow tiddlers, they seem to be there (the >>>>>>> shadow >>>>>>> tiddler is overwritten). >>>>>>> >>>>>>> But it doesn't seem to change anything -- files with multiple lines >>>>>>> added are still created as text files, not JSON. >>>>>>> >>>>>>> Thanks! >>>>>>> >>>>>> -- You received this message because you are subscribed to the Google Groups "TiddlyWiki" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/c854482c-9c65-465d-8b8e-d35f32a8278do%40googlegroups.com.
