@pmario It isn't a perfect solution but it would significantly decrease the
chances of clashes with other plugins if you tweak/extend popup.js instead
of overwriting.
So you would need to overwrite handleEvent and add pulseElement and
clickAnimation methods.
Something like:
/*\
title: $:/plugins/wikilabs/popup-tweaks.js
type: application/javascript
module-type: startup
\*/
var Popup = require("$:/core/modules/utils/dom/popup.js").Popup;
Popup.prototype.clickAnimation = function.....
I expect we are going to need to extend or refactor the popup mechanism for
the new flexbox layout. So we can keep in mind at that time to add hooks
where it might seem appropriate.
On Monday, December 28, 2020 at 4:36:10 PM UTC+1 PMario wrote:
> On Monday, December 28, 2020 at 3:52:27 PM UTC+1 Saq Imtiaz wrote:
>
> click-effect completely overwrites $:/core/modules/utils/dom/popup.js ,
>> making it impossible to use with any plugins that extend the popup class.
>>
>
> Yea, that's a problem. .. I think the core popup.js should provide a
> possibility to extend its function. .. The "element pulse" is already part
> of the core, but doesn't work. .. So we need a fix anyway. ...
>
> Do you have an idea, how we could extend the core, to make it easier for
> plugin authors?
> -mario
>
>
>
>
--
You received this message because you are subscribed to the Google Groups
"TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/tiddlywiki/a36b7fe6-96cf-4c57-a118-eb36bde6042fn%40googlegroups.com.
