> Ok, I just tested the plugin in a clean tiddlywiki. Works as expected,
> except that when you call the regular showPopup, the popup covers up
> the calling element.

oops.  That's a bug... good catch!

> No biggie, but the following line needs to be
> changed in the code:
> from:
> var offset={x:0,y:this.getAttribute('above')=='true'?-
> jQuery(d).outerHeight():0};
> to:
> var offset={x:0,y:this.getAttribute('above')=='true'?-
> jQuery(d).outerHeight():jQuery(this).outerHeight()};

Popup.show() already does that calculation, but not when
valign=='top'.  The correct fix is:

if (this.getAttribute('above')!='true') Popup.show();
else Popup.show('top','left',{x:0,y:-jQuery(d).outerHeight()});

This ensures that the standard popup handling (including any core-
computed offsets) is applied except for the specific case we are
concerned with (valign=='top').

Get the update (v2.0.1) here:
   http://www.TiddlyTools.com/#ShowPopupPlugin
   http://www.TiddlyTools.com/#ShowPopupPluginInfo

enjoy,
-e

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWiki" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/tiddlywiki?hl=en.

Reply via email to