Hi Eric, thanks for the comments. I didn't know you had an "enhanced" version on your site - I'll grab it!
Your comments are all valid. As for the warnings etc., what I was aiming for was to *prevent* a Tiddler from being deleted. I've broken my installs too many times by not understanding what I can wipe and what is critical to leave in place, and I've seen many people here do the same! So, having all my "critical" Tiddlers tagged "dontDelete" plus this TrashPlugin tweak, works perfectly for me. Personally, I think this kind of functionality (preventing critical Tiddlers from being deleted) should really be part of TW core! Cheers, David On Feb 12, 11:46 pm, Eric Shulman <[email protected]> wrote: > On Feb 12, 6:42 pm, David Szego <[email protected]> wrote: > > > Oddly, exactly 6 years after the last version, I've added a feature to > > Ido Magal's "TrashPlugin". Now the Delete button won't do anything on > > Tiddlers tagged with "dontDelete". > > Actually, I helped Ido to write the initial TrashPlugin. However, Ido > has not been active in the TW community for many years, and I long ago > 'adopted' the plugin on TiddlyTools, where it has been updated > *several* times since 2006, including fixes for the IE page transition > problem (where deleting tiddlers causes IE to ask "are you sure you > want to leave this page?"). > > With regard to your specific feature change (adding support for a > 'dontDelete' tag), I can understand *why* you might want this. > However, your implementation results in *no* action at all in response > to a user clicking the 'delete' command. Without feedback, such a non- > response would make the command seem *broken* rather than it being a > specifically-intended 'safety feature'. Note also that, with the > TrashPlugin enabled, deleted tiddlers are just tagged with > "trash" (and "excludeLists", etc.) and are not actually removed from > the document until you use the <<emptyTrash>> command, and then you > get a confirmation message anyway, that helps to ensure that people > won't "accidentally" delete a critical tiddler (most of which have > fallback *shadow* definitions anyway, e.g., ViewTemplate, > EditTemplate, etc.). > > What I am inclined to add to the 'official' version of the plugin is > support for a "trashWarning" tag, which would ask for *confirmation* > before trashing a tiddler tagged with that value. The warning message > would be something like: > "'%0' is an important tiddler and removing it may produce > unexpected side effects. Remove anyway?" > > enjoy, > -e > Eric Shulman > TiddlyTools / ELS Design Studios > > ---- > WAS THIS ANSWER HELPFUL? IF SO, PLEASE MAKE A DONATION > http://www.TiddlyTools.com/#Donations > note: donations are directly used to pay for food, rent, > gas, net connection, etc., so please give generously and often! > > Professional TiddlyWiki Consulting Services... > Analysis, Design, and Custom Solutions: > http://www.TiddlyTools.com/#Contact -- You received this message because you are subscribed to the Google Groups "TiddlyWiki" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/tiddlywiki?hl=en.
