Excellent,

Cheers,

Ton



On Tuesday, December 17, 2013 2:15:00 PM UTC+1, Jeremy Ruston wrote:
>
> Hi Ton
>
> It's turned out to be the same bug as #223, and should be fixed by this:
>
>
> https://github.com/Jermolene/TiddlyWiki5/commit/a5f33d875b1339b08838203a4885f8a3a7d10353
>
> Best wishes
>
> Jeremy
>
>
>
> On Tue, Dec 17, 2013 at 11:47 AM, Jeremy Ruston 
> <[email protected]<javascript:>
> > wrote:
>
>> Hi Ton
>>
>> Thanks for this, I'm tracking down now.
>>
>> Best wishes
>>
>> Jeremy
>>
>>
>> On Tue, Dec 17, 2013 at 10:59 AM, Ton Gerner <[email protected]<javascript:>
>> > wrote:
>>
>>> Hi all, especially Jeremy,
>>>
>>> Clicking the button (to the right of the Save button [1] executes the 
>>> code once: the tiddler width is increased and the Sidebar is shifted.
>>> After that the Javascript error appears.
>>>
>>> Hope that helps.
>>>
>>> Cheers,
>>>
>>> Ton
>>>
>>>
>>> On Monday, December 16, 2013 3:23:57 PM UTC+1, Ton Gerner wrote:
>>>>
>>>> [TW5] - Bug? Adding button to Page Control buttons gives Javascript 
>>>> error
>>>>
>>>> Hi all, especially Jeremy,
>>>>
>>>> After simplifying the code/styles for toggling the Sidebar [1] I wanted 
>>>> to make a button for increasing the tiddler width (say with 200px) and 
>>>> shifting the sidebar with the same amount (200px).
>>>>
>>>> The button - when placed in the SiteSubtitle - works, see [2].
>>>>
>>>> Tagging the button with $:/tags/PageControls adds it to the Page 
>>>> control buttons.
>>>> Clicking the button over there gives a Javascript error: "uncaught 
>>>> exception: node not found in parents children".
>>>> The button $:/toggle-width-button contains code + (hidden) styles.
>>>> When the (hidden) styles are left out, clicking the button gives a 
>>>> Javascript error with: "uncaught exception: node not found in parents 
>>>> children".
>>>> It looks like the fieldmangler code gives the error.
>>>> A MTC is available at [2]
>>>>
>>>> To be sure, I also checked [1].
>>>> The 'Toggle sidebar' button in [1] is placed in a top menu and works as 
>>>> expected.
>>>> Adding the button to the page control buttons by tagging it with 
>>>> $:/tags/PageControls gives a Javascript error when clicked.
>>>>
>>>> Any idea what is going wrong?
>>>>
>>>> Cheers,
>>>>
>>>> Ton
>>>>
>>>> [1] http://tw5toolbar.tiddlyspot.com/ (tiddler: A 'Toggle sidebar' 
>>>> button)
>>>> [2] http://tongerner.tiddlyspot.com/
>>>>
>>>>
>>>>  -- 
>>> You received this message because you are subscribed to the Google 
>>> Groups "TiddlyWiki" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to [email protected] <javascript:>.
>>> To post to this group, send email to [email protected]<javascript:>
>>> .
>>> Visit this group at http://groups.google.com/group/tiddlywiki.
>>> For more options, visit https://groups.google.com/groups/opt_out.
>>>
>>
>>
>>
>> -- 
>> Jeremy Ruston
>> mailto:[email protected] <javascript:>
>>  
>
>
>
> -- 
> Jeremy Ruston
> mailto:[email protected] <javascript:>
>  

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/tiddlywiki.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to