Hi Jim

Great stuff, that's a fine start. A couple of notes:

- In ThumbnailWidget.prototype.execute() you are reading some attributes
(eg "filter") that aren't currently being used
- In ThumbnailWidget.prototype.refresh() you are not checking the
attributes that you're using (ie url, title, class, and maybe others)
- There's an extraneous function
ThumbnailWidget.prototype.handleChangeEvent() that is not being used

You might be better off reading the bitpixels code from a system tiddler,
for example:

var BITPIXEL_API_CODE = "$:/BitPixelApiCode";
...
var code = this.wiki.getTiddlerText(BITPIXEL_API_CODE)

Ideally, you'd also check for changes to the value of that tiddler in your
refresh() method.

Best wishes

Jeremy




On Sat, Jan 4, 2014 at 5:59 AM, James Weaver <[email protected]>wrote:

> TiddlerWiki5 colleagues,
>
> The Life at a Glance TiddlerWiki is available for feedback [1]
>
> At the top of the wiki's starter page is a link to a tiddler that contains
> the TiddlyWiki hangout #27 video in which I point out some of the features
> of Life at a Glance.  A big thanks to the TiddlerWiki community, including
> Chris Hunt for instructions on creating widgets [2].  I referenced these
> instructions when creating a web page <thumbnail> widget, as you can see in
> the "Sign up on Virgin Galactic website" tiddler.  The code for the widget
> itself is in the $:/javafxpert/widgets/thumbnailWidget tiddler.
>
> I would appreciate feedback on any aspects of this wiki, including the
> functionality and best TW5 practices.
>
> [1] http://JavaFXpert.com/life-at-a-glance.html
> [2] http://cjhunt.github.io/
>
> Thanks,
> Jim Weaver
>
> --
> You received this message because you are subscribed to the Google Groups
> "TiddlyWiki" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> To post to this group, send email to [email protected].
> Visit this group at http://groups.google.com/group/tiddlywiki.
> For more options, visit https://groups.google.com/groups/opt_out.
>



-- 
Jeremy Ruston
mailto:[email protected]

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/tiddlywiki.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to