Hi Knut > Just a quick heads-up that these two (very minor) issues are still present: > If some text in the middle of a paragraph is selected, the block markup > (code/quote/list/numbered list/headings) buttons fail to insert the empty > leading line needed for correct rendering mono-block and quote are easy, and I’ve made the necessary changes here:
https://github.com/Jermolene/TiddlyWiki5/pull/2315/commits/3264499764d425a6949c9787fa316ee505b68458 The others are harder. The trouble is that there are cases where one wouldn’t want the extra line inserted, particularly if the preceding line were another heading or list item. I’m not sure the best way to address it; anyhow, the operation is implemented here: https://github.com/Jermolene/TiddlyWiki5/blob/text-editor/core/modules/editor-operations/text/prefix-lines.js > For excising text, I believe linking would be a better default than > transclusion. (unless you've changed your mind about this) I am thinking of sticking with transclusion as the default, not so much because it is the most useful as that it is the most vivid first experience. > Bad news: Most buttons don't work on Microsoft Edge (somewhat ironically, > undo/redo do work). Looks like a problem with scripting changes to the editor > widget; no error messages on the JS console. Not an issue for me personally, > I just happened to test with Firefox on Windows 10 so I gave it a quick shot > with Edge as well; just letting you know. I just downloaded a VM of Windows 10 with Edge for testing, and interestingly, it seems that the toolbar buttons do work (including the shortcuts), but the textarea updating is buggy - try using the toolbar with the preview pane open to see what I mean. I’ll investigate further; perhaps there’s some magic that will trigger the textarea to redisplay itself correctly. Many thanks, Jeremy. > > > Cheers, > Knut > > -- > You received this message because you are subscribed to the Google Groups > "TiddlyWiki" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] > <mailto:[email protected]>. > To post to this group, send email to [email protected] > <mailto:[email protected]>. > Visit this group at https://groups.google.com/group/tiddlywiki > <https://groups.google.com/group/tiddlywiki>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/tiddlywiki/29b875b0-e8b0-4935-ae36-20b7e7dd54e1%40googlegroups.com > > <https://groups.google.com/d/msgid/tiddlywiki/29b875b0-e8b0-4935-ae36-20b7e7dd54e1%40googlegroups.com?utm_medium=email&utm_source=footer>. > For more options, visit https://groups.google.com/d/optout > <https://groups.google.com/d/optout>. -- You received this message because you are subscribed to the Google Groups "TiddlyWiki" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/tiddlywiki. To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/DA44960D-FC4E-4EB9-9C80-0A2572A1E9A6%40gmail.com. For more options, visit https://groups.google.com/d/optout.
