On Wednesday, July 13, 2016 at 2:01:58 PM UTC-7, [email protected] wrote: > > I simply removed the tc-popup-keep references from the macro so that it > looks like like the below snippet. Was this the right thing to do to make > the scrollable popup a non-sticky popup? >
Though I'm not really familiar with the code for Jed's plugin, the change you suggest (omiting the hard-coded "tc-popup-keep") seems logical. One caveat: if you change someone's published plugin code, it's VERY important to change the name of any tiddlers you've modified. This especially so if you intend to post your document online for others to read. Anytime a document is posted, it is a potential source for others to copy the installed plugins (they doesn't have to be published to the TW5 plugin library for people to copy the installed shadow tiddlers directly). If the plugins have been modified but the names are unchanged, they may not realize it and they will think they are getting the "official" published version with all functionality intact (i.e., the default "tc-popup-keep" behavior). My general suggestion is to add your initials to the end of the installed tiddler names (e.g., "SomePlugin" becomes "SomePlugin_ABC"). Similarly, you might also want to add your initials to the names of any internal macro functions that you've changed (e.g., "PopoutMenuScrollable" becomes "PopoutMenuScrollable_ABC"). Of course, this means changing every place the macro is *used* (not just it's definition). The advantage of renaming the modified functions is that the altered plugin can then co-exist with the standard, unmodified version, allowing use of both within the same document. enjoy, -e Eric Shulman TiddlyTools / ELS Design Studios InsideTiddlyWiki: The Missing Manuals -- You received this message because you are subscribed to the Google Groups "TiddlyWiki" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/tiddlywiki. To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/fc55edd6-7a02-4668-86d4-ea76b5c6173d%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
