After another multi-round fight and lots of sweat and tears I finally managed to make the external images button in the Editor Toolbar allow inserting external images by writing or pasting their URL.
Created a pull request here https://github.com/Jermolene/TiddlyWiki5/pull/2548 Again not sure if it is over complicated or totally correct codewise, but could not make it work without so many macros. It may need a few language hints Here it is in action <https://lh3.googleusercontent.com/-WD3W_JDfIW0/V7rwTcSyGTI/AAAAAAAAQo8/7WAE0GcB8SkgOKqm9uECH9NVHthtLy_9ACLcB/s1600/TiddlyWiki_ExternalImage.gif> Ideally the text box would also allow filtering or searching the internal image tiddlers displayed in the list bellow, just like the links button dropdown currently, but I'll just leave it as a hint for Jeremy as a possible future improvement, since that is way above my skill level. Hope you guys find this useful. On Sunday, 7 August 2016 14:48:21 UTC+1, Duarte Farrajota Ramos wrote: > > It seems Jeremy liked it enough, a commit has been submitted > <https://github.com/Jermolene/TiddlyWiki5/issues/2521#issuecomment-238072286> > that includes this feature :) > This also allows linking to non existing tiddlers too. > > I will try again my luck with inserting external images too in the next > few days. I'll post any results if I am successful. > > Thanks Jeremy > > On Wednesday, 3 August 2016 19:26:56 UTC+1, Duarte Farrajota Ramos wrote: >> >> Ah nice one, was wondering if one could submit the code somewhere, but >> you already did it, so I thank you for that. >> I urge you to look at the code though, to see if it could be improved, as >> I said my coding skills are non-existant >> >> Anyway I was plugging away at the external image feature, but could not >> do it myself. I may try again but I fear it's way above me. >> >> On Wednesday, 3 August 2016 12:57:14 UTC+1, PMario wrote: >>> >>> On Tuesday, August 2, 2016 at 9:38:13 PM UTC+2, Duarte Farrajota Ramos >>> wrote: >>>> >>>> So eventually I'd like to do something similar for external images too, >>>> possibly combined with the existing insert image button or even as a >>>> different one, but I fear my ineptitude may get in my way. I will try it >>>> again later tonight, but it may well be far above my copy-pasting skills. >>>> >>>> Anyway, what do you guys think, is this worth it, is it useful? >>>> >>> >>> Well done! Looks good to me and seems to be very useful! >>> >>> >>>> Jeremy would you consider including something vaguely like this in any >>>> future release? Perhaps even as a different button, or combined with the >>>> current ones? >>>> >>> >>> Would be worth a new feature request. .. >>> https://github.com/Jermolene/TiddlyWiki5/issues/2521 ... you can create >>> them yourself ;) >>> >>> have fun! >>> mario >>> >>> >>> >> -- You received this message because you are subscribed to the Google Groups "TiddlyWiki" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/tiddlywiki. To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/b952d4da-b55c-48e2-b4ed-6dfa7f411583%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
