Hi @Swicky,

Tobibeer's preview plugin overwrites the same shadow tiddler as the 
navigator plugin ($:/core/modules/utils/dom/popup.js)

the preview plugin relies on the "cancel" method in its popup.js, which is 
not there in the navigator-popup.js ... the navigator plugin has a 
different popup mechanism ... it's experimental

so I'd recommend no using the navigator. it has some nice functionality and 
whenever possible I try making parts of it ready for a pull request to be 
merged with the core, but it's not thaaat easy ...

as you noticed, it's sensible not to break other plugins, keeping backwards 
compatibility ... the navigator is a little black sheep in that context. 
it's more a that-would-be-nice-to-have demo

I'm more and more trying not to overwrite core shadow tiddlers, the 
navigator though overwrites a whole bunch of them


best wishes,
btc
 

> Hello! I'm trying to put BurningTreeC's Navigator plugin 
> <https://burningtreec.github.io/TW5-navigator/> and Tobibeer's Preview 
> plugin <https://tobibeer.github.io/tw5-plugins/#preview> in the same 
> wiki. However, I'm having a little trouble, and can't figure out why.
>
> With Navigator, escapecss[] (Navigator's dependency), and Appear 
> (Preview's dependency) in the wiki, it breaks. If I import these into an 
> empty, same problem. It shows this error:
>
> Internal JavaScript Error
> Well, this is embarrassing. It is recommended that you restart TiddlyWiki 
> by refreshing your browser
> TypeError: this.cancel is not a function
>
> But only once I click. I can use hotkeys all I like, but as soon as I 
> click, that error pops up. It's really weird..
>
> In addition, you might have noticed this error is with Navigator and 
> Appear. I'd like to know what's causing this, how to fix it, and if 
> anything else might stop working once I add Preview itself.
>
> Any help appreciated! (Also, sorry if any of these names are off - please 
> correct me!)
>

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywiki+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywiki@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywiki/90644934-4a8e-460c-b58e-6944c290b73d%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to