Hi,
I think Jayfresh and I spotted a regression in jquery implemention of
createTiddlyText:
function createTiddlyText(parent,text)
{
return jQuery(parent).append(text);
}
returns the parent instead of the created element.
Althought is given "<div>" as text argument it will create html
<div></div> instead of a text node with '<div>' as content.
This as the side effect of breaking TiddlyTemplating stuff:
when using a template:
<div><!--<<viewer text>>--></div>
expands to:
<div></div>text
instead of:
<div>text</div>
Would you consider reverting to the previous implementation ?
function createTiddlyText(theParent,theText)
{
return theParent.appendChild(document.createTextNode(theText));
}
#jquery guys told me that jquery provide no good way to manipulate
text
node directly.
Here is a patch, that add a test to the qunit test suite to reproduce
the issue, and revert to the createTiddlyText previous implementation.
http://pastebin.com/pastebin.php?dl=f277d195b
--
Johan Euphrosine <[email protected]>
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"TiddlyWikiDev" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/TiddlyWikiDev?hl=en
-~----------~----~----~----~------~----~------~--~---
