On Oct 20, 1:33 am, Eric Shulman <[email protected]> wrote: > This will set the access key on *every* instance of the closeAll > command. If this command occurs in more than one place in the > document, then there will be multiple DOM nodes with the same assigned > access key. This is generally not a good idea, as this can be handled > differently by different browsers.
You may be confusing two patches here. I deliberately wrote them this way but I didn't do a good job of explaining myself. The code you're reviewing sets the accessKey for the closeAll _macro_ which I had assumed goes in the sidebar only one time. The closeAll _command_ has no accessKey. One (on the macro) is enough. Also, I based my code on the accessKey-setting code for the other config.macros entries. Do they have the same problem, or does only my code have the problem because it's used differently? Perhaps the <span> trick to put the closeAll macro in toolbars? --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "TiddlyWikiDev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/tiddlywikidev?hl=en -~----------~----~----~----~------~----~------~--~---
