Hi Yakov I'm afraid I can't help with the first question, but as to the second when I view the pull request on github.com I can only see an option to merge it, and I don't see any option to reject it. From observing pull requests made by others I got the impression that the sender can modify them after they are sent but before they are accepted.
Best wishes Jeremy -- Jeremy Ruston [email protected] On 2 Jan 2013, at 19:10, Yakov <[email protected]> wrote: Hi. after making the first pull request [1], I've got two issues: first, Mario pointed that there's a problem with my code according to tests [2], but I don't know how to build a test wiki under Windows. Can anyone help with this? Second, I've done a small change in my commit [3] (without tests, I don't know whether it's a fix, it's just more consistent), but as the previous request is not accepted or declined, I can't push a new one (from this branch). What do I do in such a situation? Can I withdraw it? Or is the new commit added to the first Pull Request (a comment titled "YakovL added a commit" is added to the discussion of the request)? Yakov. [1] https://groups.google.com/forum/?fromgroups=#!topic/tiddlywikidev/O3NiED8Lk9c [2] https://github.com/TiddlyWiki/tiddlywiki/pull/112 [3] https://github.com/YakovL/tiddlywiki/commit/86fbd9511a9292767485e66e33e4401cd7846d9b -- You received this message because you are subscribed to the Google Groups "TiddlyWikiDev" group. To view this discussion on the web visit https://groups.google.com/d/msg/tiddlywikidev/-/CLRGFzSFuqoJ. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/tiddlywikidev?hl=en. -- You received this message because you are subscribed to the Google Groups "TiddlyWikiDev" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/tiddlywikidev?hl=en.
