Hi Stephan > > > Yes. Using this as the HTML name-attribute of the radiobuttons. We need a > unique name, and I assume tiddler names are unique enough, for each group > of radiobuttons. >
Tiddler names are not unique enough. All it takes is for a tiddler to be displayed twice, which could happen with a hover-preview of a tiddler. You should use the same state qualifier mechanism as the other widgets. > Additionally this has the advantage that I have a textreference to the > tiddlerfield. What I'm doing there is simply prepending the current tiddler > name and "!!" provided that there is no "!!" in the fieldname. > > > >> and then you're using setTextReference() to set the field value. You >> shouldn't be using setTextReference, but rather should do the field >> modifications in the same way as the fieldmangler widget: >> > > I would have never thought that this handler set or changes a field. But > now that you've shown it to me, I recognise parts of it from the method I > used. > > To be honest: I think it's rather cumbersome to have such a long method in > each and every widget which needs to set or change a field. So I thought > the setTextReference is an appropriate choice. Why would one want to > duplicate the function of setTextReference? > Firstly, don't forget that TW5 is a work in progress. Frequently I refactor or add methods to the wiki object to capture common idioms. Here, we probably need to add a method like: wiki.setField(title,fieldName,value) Anyhow, it doesn't duplicate the functionality of text references. Don't forget that text references allow indexed property references. Your code would allow me to pass a tiddler title "##likeThis" which would then get treated wrongly by setTextReference. Best wishes Jeremy > > -- Jeremy Ruston mailto:[email protected] -- You received this message because you are subscribed to the Google Groups "TiddlyWikiDev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/tiddlywikidev. For more options, visit https://groups.google.com/groups/opt_out.
