On Monday, January 13, 2014 3:18:21 AM UTC+7, Jeremy Ruston wrote: > > Hi BJ > > On Wed, Jan 8, 2014 at 5:36 PM, BJ <[email protected] <javascript:>>wrote: > >> tiddler called 'undefined' problem >> Symptom: >> tw5 loads without the tiddlywiki stylesheets. >> Cause: >> a)During the build process, file plugins/BJ/TW5CKEditor/readme.md is >> added as a tiddler to the plugin with tile "undefined" >> b)having a tiddler with title "undefined" in the store causes the >> unpacking of the theme plugins to fail so the stylesheets tiddlers are not >> added to the store. >> > > The trigger here is that readme.md isn't a valid tiddler file without an > accompanying .meta file so that TW can assign it a title. > > I tried to duplicate the problem by adding a file called "readme.md" to > the existing tiddlywiki/fullscreenplugin. It ended up as a shadow tiddler > with the title "undefined", but I didn't see any problems with the > stylesheet handling as a result. Is there another step needed to duplicate > the problem? > 'readme.md' needs to be added to a plugin that unpacks before the themes. Another simpler to reproduce symptom is that if you add a tiddler with title 'undefined' then newly created tiddlers will have default titles 'undefined 1' etc.
> nbsp substitution error >> Symptom: >> When viewing the source html produced by ckeditor, the letters n,b,s,p >> are converted to html entities (ascii values); >> binary comparing the contents of the tiddler containing the ckeditor.js >> (copied from an edit tiddler textarea) with the original ckeditor.js shows >> that the value 0xA0 is replaced with the string 'nbsp' >> cause: >> innerHTML returns "non-breaking space" character as the string " " >> and so substitutions will occur in tiddlers that are unpacked from plugins. >> Proposed solution: >> add >> replace(/ /mg," ") >> to $tw.utils.htmlDecode() in boot.js >> > > That makes sense, fixed here: > > > https://github.com/Jermolene/TiddlyWiki5/commit/b5d2b79a372f4bd1faf5d801f92b84929fe46c47 > > >> new edit widget integration >> Requirement: A new edit widget need to be associated with the tiddlers of >> mime-type text/html >> >> Proposed Implementation:- generally use the 'extension' of the mime-type >> as an appendage to 'edit-' as names for edit widgets that are added as >> extensions, (in this case edit-html) and use a different name for the >> default edit widgets (as is already the case for all types so far) >> At present we have 'edit-text' as the built-in assigned editor for >> text/html (.html), so this extension defines an 'edit-html' widget and this >> gets selected by the edit widget for text/html tiddlers in preference to >> the build in default. >> >> The advantage to this naming scheme is that if extensions add new tiddler >> types (along with an editor) to TW5 the edit widget does not need to be >> changed. >> >> See the proposed code changes to edit.js >> > > That looks good, and ready for a pull request apart from some differences > from TW house coding style. I've just started to document it here: > > > https://github.com/Jermolene/TiddlyWiki5/blob/master/editions/tw5.com/tiddlers/dev/Naming%20of%20System%20Tiddlers.tid > > >> >> style sheet loading order >> There is no proposed change for this issue, having temporal ordering to >> loading files for plugins would be complicated. >> >> symptoms: >> ckeditor 'appears' invisible when editing a text/html tiddler. >> cause: >> when ckeditor.js is initialised it first loads an internally created >> 'hide' style sheet, then it normally loads external 'display' stylesheets, >> which override the 'hide' style sheet (precedence is determined by the >> order of loading). In TW5 stylesheets from tiddlers are loaded before >> modules are initialised, and thus style sheets are in the wrong pecking >> order (for ckeditor). >> Work around: >> leave off the "$:/tags/stylesheet" tags on css tiddlers and load the >> stylesheets programmatically by the widget module when it is initialised. >> > > That makes sense, and you're right that adding the stylesheet manually is > a good pragmatic workaround. > > Many thanks, > > Jeremy > > >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "TiddlyWikiDev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> To post to this group, send email to [email protected]<javascript:> >> . >> Visit this group at http://groups.google.com/group/tiddlywikidev. >> For more options, visit https://groups.google.com/groups/opt_out. >> > > > > -- > Jeremy Ruston > mailto:[email protected] <javascript:> > -- You received this message because you are subscribed to the Google Groups "TiddlyWikiDev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/tiddlywikidev. For more options, visit https://groups.google.com/groups/opt_out.
