Hello guys,

today I've took a look at the code of the String.prototype.escapeRegExputility 
[1] and noticed that it doesn't escape the "-" and the "/" 
characters. While I'm not sure about "/", "-" should be escaped for sure as 
it generates ranges ("a-c"). For instance, /[!-\/]/ and /[!\-\/]/ are 
different things, the first matching * and the second not matching. In 
TiddlyWiki5, it looks ok [2]. In fact, I like the short (and faster) 
version of the function from TW5 better, so I propose to copy-paste it from 
TW5 to TWc.

Best regards,
Yakov.

[1] https://github.com/TiddlyWiki/tiddlywiki/blob/master/js/Strings.js#L50
[2] 
https://github.com/Jermolene/TiddlyWiki5/blob/master/core/modules/utils/utils.js#L354

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/tiddlywikidev.
For more options, visit https://groups.google.com/d/optout.

Reply via email to