Hi James
> I got the actionwidget thing working, very nice. > Great.. > Nowi just need a hook into story.js. Any ideas or plans on how you are > going to do this? I have some free time coming up and might be able to give > it a go, > I'm thinking of introducing a new general purpose "hooking" mechanism. You'd register a hook for altering the default tiddlers something like this: $tw.hooks.addHook("th-opening-default-tiddlers-list",function(list) { list.push("Another tiddler"); return list; }); I've created a ticket here: https://github.com/Jermolene/TiddlyWiki5/issues/1064 Best wishes Jeremy > > thanks > > , > James > > > On Tuesday, 4 November 2014 06:38:22 UTC+9, James Anderson wrote: >> >> http://welford.github.io/#%24%3A%2Fcore%2Fmodules%2Fstartup%2Fstory.js >> >> The same issue appears on my older webpage too. Will investigate this >> later. >> >> On Tuesday, 4 November 2014 06:26:29 UTC+9, Jeremy Ruston wrote: >>> >>> Hi James >>> >>> No, the code highlighting is completely wrong in the JS tiddler I linked >>> to. Very strange. >>> >>> Best wishes >>> >>> Jeremy. >>> >>> >>> On Mon, Nov 3, 2014 at 9:22 PM, James Anderson <james.w....@gmail.com> >>> wrote: >>> >>>> You mean the spacing that is added throughout the code block? I have no >>>> idea, that is the first time I have noticed it, >>>> >>>> I'll take a look at action-sendmessage when i have some time. >>>> >>>> Thanks, >>>> James >>>> >>>> >>>> >>>> On Tuesday, 4 November 2014 06:13:43 UTC+9, Jeremy Ruston wrote: >>>> >>>>> Hi James >>>>> >>>>> >>>>>> I understand that the plugin in it's current form is not suited for >>>>>> upgrades at all. For this to work as an reliable plugin I need a way to >>>>>> append to the default tiddlers in story.js on startup or when the home >>>>>> button is pressed (which i currently don't do). I think $:/DefaultTidders >>>>>> list field is well suited to this (unless there is some unknown use for >>>>>> it >>>>>> that I am unaware of). I also need a way to add custom messages to >>>>>> buttons, >>>>>> though this is not as important as it could be also be it's own custom >>>>>> button and work just as well. >>>>>> >>>>>> Ideally however, I think this functionality would be good to have in >>>>>> the core and I don't mind cleaning this up and making a pull request for >>>>>> it. Opinion here seems divided (biased though I am, I'd say that the >>>>>> average person here was more inclined to know programming and don't see >>>>>> the >>>>>> barrier for those not in the know :) ) I think that 2nd version is very >>>>>> unobtrusive and easily ignored for those that do not like the idea) >>>>>> >>>>> >>>>> I'm not in favour of adding it to the core at this point. I'd prefer >>>>> to get more usage and feedback from the community as a plugin. Part of the >>>>> reason is that I can imagine a few different ways of handling a tiddler >>>>> "pin" button - for example, to be able to pin tiddlers to a different >>>>> story >>>>> tiddler so that they show up in a separate column for reference. Or >>>>> pinning >>>>> tiddlers to a new title list in the sidebar. This is quite a high level >>>>> behaviour change and so I think it's is best handled through a plugin to >>>>> encourage experimentation (once it's in the core it would be frozen). >>>>> >>>>> Anyhow, I think we'd only need one core change which is to update >>>>> story.js so that external modules get a chance to change the default >>>>> tiddlers before they are used. >>>>> >>>>> I think you can avoid customising the button widget by using the new >>>>> action-sendmessage widget to send a message with parameters. >>>>> >>>>> By the way, the highlight plugin seems to be misbehaving for me on >>>>> your site. For example: >>>>> >>>>> http://welford.github.io/pinned2.html#%24%3A%2Fcore%2Fmodule >>>>> s%2Fstartup%2Fstory.js >>>>> >>>>> I couldn't see anything obvious that might cause the problem, have you >>>>> any idea? >>>>> >>>>> Best wishes >>>>> >>>>> Jeremy. >>>>> >>>>> >>>>>> >>>>>> Thanks again, >>>>>> James >>>>>> >>>>>> On Tuesday, 4 November 2014 02:01:31 UTC+9, Jeremy Ruston wrote: >>>>>>> >>>>>>> Hi James >>>>>>> >>>>>>> I just noticed that your example at http://welford.github.io/pi >>>>>>> nned2.html ships with updated versions of two of the core shadow >>>>>>> tiddler JS modules "story.js" and "button.js". That's not a good >>>>>>> strategy >>>>>>> for a production plugin as it will not withstand a core upgrade. >>>>>>> Ideally, >>>>>>> we'd work together to get the hooks you need in story.js and button.js. >>>>>>> Failing that, I think it would be helpful for end users to give a very >>>>>>> clear warning that the plugin will not work through future core >>>>>>> upgrades. >>>>>>> >>>>>>> Best wishes >>>>>>> >>>>>>> Jeremy >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Mon, Nov 3, 2014 at 4:57 PM, Jeremy Ruston <jeremy...@gmail.com> >>>>>>> wrote: >>>>>>> >>>>>>>> Hi James >>>>>>>> >>>>>>>> That should read i had a bit of trouble with the filters. They work >>>>>>>>> as they are now, i am just not too sure on the need to [all] in one >>>>>>>>> and >>>>>>>>> [is] in the other. >>>>>>>>> >>>>>>>> >>>>>>>> "is" acts as a filter, filtering the currently selected tiddlers >>>>>>>> according to its operands. "all" acts as a generator, ignoring the >>>>>>>> currently selected tiddlers, and just generating tiddler titles >>>>>>>> according >>>>>>>> to its operands. >>>>>>>> >>>>>>>> >>>>>>>> Best wishes >>>>>>>> >>>>>>>> Jeremy >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On Monday, 3 November 2014 04:22:54 UTC+9, James Anderson wrote: >>>>>>>>>> >>>>>>>>>> http://welford.github.io/pinned2.html >>>>>>>>>> >>>>>>>>>> A new version which does what I previously mentioned: Using the >>>>>>>>>> list field of $:/DefaultTiddlers as not to created any unwanted >>>>>>>>>> duplicate >>>>>>>>>> data or update the modified field of any tiddler you wish to pin. >>>>>>>>>> >>>>>>>>>> For this plugin the button widget has 2 new parameters for the >>>>>>>>>> tm-add-field message (both in place of setTo) "appendFront" and >>>>>>>>>> "remove" >>>>>>>>>> which append data to the front of a field and removes and entry from >>>>>>>>>> a >>>>>>>>>> field respectively. >>>>>>>>>> >>>>>>>>>> story.js has been modified to look at the list field of >>>>>>>>>> $:/DefaultTiddlers and append and tiddlers appearing in the field >>>>>>>>>> but not >>>>>>>>>> in the parsed body. >>>>>>>>>> >>>>>>>>>> I have a bit of trouble getting the filters to do what i wanted >>>>>>>>>> without using tags. >>>>>>>>>> >>>>>>>>>> <$list filter="[all[current]]-[list[$:/DefaultTiddlers]]"> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> This is what i ended up with for catching tiddlers that were not >>>>>>>>>> already pinned, it doesn't work for system tiddlers (like control >>>>>>>>>> panel) >>>>>>>>>> when using is[current] instead of all[current], if anyone could tell >>>>>>>>>> me why >>>>>>>>>> i'd love to know >>>>>>>>>> >>>>>>>>>> <$list filter="[list[$:/DefaultTiddlers]is[current]]"> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> And this catched tiddlers that are already pinned, but again (if >>>>>>>>>> inversely) all[current] did not work correctly for system tiddlers >>>>>>>>>> like >>>>>>>>>> control panel. Any help on clearing up why would be appreciated. >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> James >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Monday, 27 October 2014 05:00:37 UTC+9, James Anderson wrote: >>>>>>>>>>> >>>>>>>>>>> Thanks, I had mobile in mind for some TW5 apps that I am making. >>>>>>>>>>> the sidebar hides below a certain screen width. >>>>>>>>>>> >>>>>>>>>>> I have an updated version that hides the page name too, so there >>>>>>>>>>> is more space for the toolbar and search on phones. >>>>>>>>>>> >>>>>>>>>>> On Monday, 27 October 2014 04:11:59 UTC+9, Danielo RodrÃguez >>>>>>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>> Hello James >>>>>>>>>>>> >>>>>>>>>>>> Personally I don't see the need of pin tiddlers, using default >>>>>>>>>>>> tiddlers plus tags is good enough for me. Anyway, having the >>>>>>>>>>>> ability to >>>>>>>>>>>> customize TW to everyone's liking is one of its strongest features. >>>>>>>>>>>> >>>>>>>>>>>> BTW I only wanted to say that I love how your TW is displayed >>>>>>>>>>>> on my mobile phone. The top bar is very handy and non intrusive. >>>>>>>>>>>> Maybe I >>>>>>>>>>>> miss a couple of buttons. Is the sidebar hidden always or just on >>>>>>>>>>>> mobile? >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>> You received this message because you are subscribed to the Google >>>>>>>>> Groups "TiddlyWikiDev" group. >>>>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>>>> send an email to tiddlywikide...@googlegroups.com. >>>>>>>>> To post to this group, send email to tiddly...@googlegroups.com. >>>>>>>>> Visit this group at http://groups.google.com/group/tiddlywikidev. >>>>>>>>> For more options, visit https://groups.google.com/d/optout. >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Jeremy Ruston >>>>>>>> mailto:jeremy...@gmail.com >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Jeremy Ruston >>>>>>> mailto:jeremy...@gmail.com >>>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Jeremy Ruston >>>>> mailto:jeremy...@gmail.com >>>>> >>>> >>> >>> >>> -- >>> Jeremy Ruston >>> mailto:jeremy...@gmail.com >>> >> -- Jeremy Ruston mailto:jeremy.rus...@gmail.com -- You received this message because you are subscribed to the Google Groups "TiddlyWikiDev" group. To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywikidev+unsubscr...@googlegroups.com. To post to this group, send email to tiddlywikidev@googlegroups.com. Visit this group at http://groups.google.com/group/tiddlywikidev. For more options, visit https://groups.google.com/d/optout.