Hi All,

The popup mechanism not working with external windows is definitely a bug, and 
it would be terrific to fix it. As you’ve discovered, the two mechanisms were 
written without regard for one another:

https://github.com/Jermolene/TiddlyWiki5/blob/master/core/modules/startup/windows.js
 
<https://github.com/Jermolene/TiddlyWiki5/blob/master/core/modules/startup/windows.js>
 - for the open-in-new-window stuff
https://github.com/Jermolene/TiddlyWiki5/blob/master/core/modules/utils/dom/popup.js
 
<https://github.com/Jermolene/TiddlyWiki5/blob/master/core/modules/utils/dom/popup.js>
 - for the popup mechanism

I agree with Andreas that the fix is to essentially duplicate an instance of 
the popup mechanism for each opened window. I wonder if triggerPopup could 
check the ancestors of the domNode to see which window the popup is in, and 
route it accordingly.

Best wishes

Jeremy.



> On 21 Feb 2018, at 19:07, Simon Huber <[email protected]> wrote:
> 
> No - I'm not having success. Here I depend on help from above
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "TiddlyWikiDev" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to [email protected] 
> <mailto:[email protected]>.
> To post to this group, send email to [email protected] 
> <mailto:[email protected]>.
> Visit this group at https://groups.google.com/group/tiddlywikidev 
> <https://groups.google.com/group/tiddlywikidev>.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/tiddlywikidev/31f5df4c-5e0b-4527-be06-7a6133f0f1f7%40googlegroups.com
>  
> <https://groups.google.com/d/msgid/tiddlywikidev/31f5df4c-5e0b-4527-be06-7a6133f0f1f7%40googlegroups.com?utm_medium=email&utm_source=footer>.
> For more options, visit https://groups.google.com/d/optout 
> <https://groups.google.com/d/optout>.

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/8BF85989-573F-4D65-B1A0-5945AC6C6026%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to