Actually I had added dirty indicator to Tiddloid in the latest commit(not in released apk yet).
在 2019年6月23日星期日 UTC+8下午4:43:15，TonyM写道： > > Yakov > > I have done some research into the dirty indicator and is relates to > browsers and some css on the body element. A fuynction is called when > numbchanges > 0 to do something equivalent to > > https://stackoverflow.com/questions/6275983/cancel-onbeforeunload-event-handler > > this.$window.onbeforeunload = () => undefined; > > OR > > > window.onbeforeunload = function () { > // blank function do nothing > } > > > It is the browser causing the popup, and I expect the local storage > plugin, Tiddloid, Bob and others are not ensuring this trigger is stopped > after saving, so the browser will not let the window/tab close without a > message after saving is complete, even although all is saved. It just asks > are you sure we want to leave, If you may another change this will be > triggered again. > > See $:/core/modules/saver-handler.js > > Update the document body with the class "tc-dirty" if the wiki has > unsaved/unsynced changes > */ > SaverHandler.prototype.updateDirtyStatus = function() { > if($tw.browser) { > $tw.utils.toggleClass(document.body,"tc-dirty",this.isDirty()); > } > }; > > > > Regards > Tony > > > > > On Sunday, June 23, 2019 at 3:18:04 AM UTC+10, Yakov wrote: >> >> Hi, >> >> this is a great addition to TW saving ecosystem, thanks! >> >> Some notes: >> >> - donmor, looks like you have adapted the saving engine from >> TiddlyFox; it there any particular reason why you restricted >> >> <https://github.com/donmor/Tiddloid/blob/c54a1632e4b5116d41ff43f5537b64da288be1f2/app/src/main/res/values/strings.xml#L31> >> >> loading to just TW itself instead of loading via xhr like in TF >> <https://github.com/TiddlyWiki/TiddlyFox/blob/master/data/inject.js#L33>? >> It doesn't work or any other reason? (I'm using SharedTiddlersPlugin >> <http://yakovl.bplaced.net/TW/STP/STP.html> for customizing my TWs so >> it would be nice to enable loading) >> - load time is very nice indeed (especially compared to FireFox), >> this is great! >> - Tony, although that may be just a bug, that also may be related to >> the absence of the "saving failed" event which makes it impossible to >> write >> success reporting consistently. Recently I've proposed an extension of >> the >> event system here >> <https://groups.google.com/forum/#!topic/tiddlywikidev/e8hAHYLWUbQ>, >> I hope we'll come to an agreement about this, although there were no >> reply >> yet >> - donmor, do you have any idea how difficult would it be to extend >> the app to be multitab? >> - does Tiddloid support cookies/localStorage/.. or options should be >> "baked" to survive TW reload reopen? (well, at least is it expected >> to support cookies if you haven't tested that?) >> - where the template for new TW is held? I'd like to use a customized >> TWC instead of TW5 there, but I don't see any Tiddloid folder in main >> storage, neither I can see the definition of getFilesDir >> >> <https://github.com/donmor/Tiddloid/blob/f1031c75dc93dcbe072c8547096406f1127d8b89/app/src/main/java/top/donmor/tiddloid/MainActivity.java#L147> >> >> in sources >> >> >> Best regards, >> Yakov. >> >> понедельник, 3 июня 2019 г., 7:35:40 UTC+3 пользователь Stefan Pfister >> написал: >>> >>> Hello, >>> >>> Really a good app with an intuitive interface. Starts verry fast on my >>> Android 6.0. I like the automatic backup function too. Well done. >>> >>> Regards >>> Stefan >>> >>> donmor3000 <[email protected]> schrieb am Mo., 3. Juni 2019, 05:29: >>> >>>> Are you using TWC in Tiddloid? Zooming buttons shows only in TWC 'cause >>>> it have no mobile mode. >>>> >>>> 在 2019年5月29日星期三 UTC+8下午6:45:28，Vincent Yeh写道： >>>>> >>>>> This is what I have been looking for! Thanks a lot, donmor3000! >>>>> >>>>> One little thing is that the little bar with zooming buttons can block >>>>> the content sometimes, would be much better if this can be avoided >>>>> somehow. >>>>> >>>>> Still, it's a nice work, thanks a lot! >>>>> >>>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "TiddlyWikiDev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To post to this group, send email to [email protected]. >>>> Visit this group at https://groups.google.com/group/tiddlywikidev. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/tiddlywikidev/9c213d5b-8d1c-4867-aa9b-563fc48998d7%40googlegroups.com >>>> >>>> <https://groups.google.com/d/msgid/tiddlywikidev/9c213d5b-8d1c-4867-aa9b-563fc48998d7%40googlegroups.com?utm_medium=email&utm_source=footer> >>>> . >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> -- You received this message because you are subscribed to the Google Groups "TiddlyWikiDev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywikidev/46cfb2ea-6691-4df0-8edd-95e24677c11a%40googlegroups.com.
