On Saturday, June 27, 2020 at 10:24:05 PM UTC+2, Mat wrote: > > > I of course don't want to delay the current PR, but it there any *other > *reason > for why not to raise this already now? >
The PR is about adding keyboard support to the tagpicker and search fields. This addition to the edit widget is an incidental by-product that I suggested in the interests of flexibility. As such, bringing up this change in this PR would be completely off-topic. This PR has nothing to do with the tiddler editor template. > > Well, if I did it for myself that'd be OK but I see two potential problems: > > 1) since this is to be a plugin I don't want to cause problems for people > Sooner or later, shadow tiddlers need to be overwritten by plugins to add features. It is rare that two plugins need to overwrite the same plugin and if that problem arises should be dealt with via documentation. No matter how much flexibility we add, for some tweaks shadow tiddler changes will always be needed. That's why they are shadows. Overriding shadows was very normal in the TWC days and rarely an issue. As a plugin writer you check the release notes for each new release of TW. If a shadow you overwrite gets updated, you update the plugin. Happens rarely. Similarly if there already exist popular plugins that overwrite the same shadow, you take that into account. Yes in an ideal world it wouldn't be necessary but practically it sometimes just has to be done. > 2) how does the priority of shadow tids actually work? Since it is a > plugin, also my template would be a shadow, so which one takes precedence? > Plugin shadow tiddlers override core shadows. -- You received this message because you are subscribed to the Google Groups "TiddlyWikiDev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywikidev/a6884ed6-1e5b-4f46-8491-386d47a350beo%40googlegroups.com.
