On Friday, July 10, 2020 at 2:36:21 AM UTC+2, TonyM wrote: ... > I have mastered the mechanism to submit changes to tiddlywiki.com because > of the pink bar > Can you help us improve this documentation? Find out how > <https://tiddlywiki.com/#Improving%20TiddlyWiki%20Documentation> to edit > this tiddler on GitHub >
Did you watch all 3 videos? ... Most answers should be there. > I need just a little help. > > > - I forked the master and submitted a change more than a year ago > - This is the only time I got recognised on a release > - A little sad given my non github work, seem only changes to gihub > core do this. > - Can I just propose changes via that same fork? > > Yes. ... If you start editing from Jeremy's "master" or "tiddlywiki-com" branch as shown in video 3. > > - Do I need to refresh the fork with the current version? > > Not necessarily. If you start from Jeremy's repo/branch you will get an updated "feature branch" in your repo. > > - Can I use the GitHub for desktop? > > I personally would say. Use something else. I did install it years ago and it had the worst user experience that I've ever seen. So may be it's time for a new test. > > - Is it sufficient to raise an issue and propose a commit, even if it > is initially rejected because of a naming standard or something more > serious? > - I find it hard to get a well developed concept taken seriously in > the issue thread, and who would give me the go ahead anyway?, it seems > I > just need to jump into the deep end and submit changes? > > Creating issues is "kind of" sufficient. ... BUT you have to find someone, who actually implements the pull request. ... So PRs have a much bigger chance, to be merged. Especially for the tiddlywiki-com <https://github.com/Jermolene/TiddlyWiki5/tree/tiddlywiki-com> branch, which is the documentation branch. ... So DOCS only! > - What about a mass change that has a minor possibility of conflict? > - I would like to propose a change to all existing buttons (#4272 > > <https://www.google.com/url?q=https%3A%2F%2Fgithub.com%2FJermolene%2FTiddlyWiki5%2Fissues%2F4272&sa=D&sntz=1&usg=AFQjCNGPJYeCdvnnkD_CyLd8OoHvViByiQ> > ) > > That's a rather big one. ... So chances are high, that there will be some discussion. ... If the discussion is controversial it may need more than 1 PR cycle. So you should start with a "POC" proof of concept. eg: 1 working button for every "toolbar" you want to change. eg: 1 button in ViewTemplate, 1 in EditTemplate, 1 in right sidebar ... If that's what you want. + Doc changes for at least 1 button ... So we can see, how the new docs would look like. Getting the docs right is probably much more work than changing the code. May be new config tab in ControlPanel .. if needed. I think, this would be the minimum amount of work, you'll need to put into the PR, to test if it would be merged. ... There is nothing more frustrating, than creating a PR which needed weeks to be built, which gets rejected. ... But that happens! ... So going with a POC has a high chance to start a discussion. You get feedback before you put too much work into it. Those discussion may lead to a completely different solution, than you may have envisioned. .. And it may take longer, than you wanted. ... But in the end There is 1 very important hurdle you have to pass. ... *Whatever lands in the core will be there "forever" and it has to be maintained "forever"*. ... Hopefully it's you that cares about this functions and you maintain them. But if not someone else *has *to do "care take care". > - However there is a slight overlap with other proposed changes in the > above issue including converting "widgets to actions" > > Overlap with proposed changes is _no_ big problem. ... Overlap with existing PRs IS!. .. So if your changes cause conflicts with other "new" PRs, you should be careful. ... If the other PRs are older than a year and still open. Go on with your PR. .. Others can make new PR if necessary. > > - How do I discuss this such as with Jeremy who was proposing a > related change, and has already done his change for new Journal/tiddler > buttons > > If the changes are already implemented in "master branch" you just use them. ... Starting from Jeremy's master. > I so wish to contribute more, but I need to takes a few more steps. > If this info isn't enough. .. Please tell. We will make it work. I know, the Videos are 6 Years old and the github UI has changed quite a bit. ... But the concept is still the same. @all If you think, the videos are already uselessly old, please tell. ... There is always room for improvements. have fun! mario -- You received this message because you are subscribed to the Google Groups "TiddlyWikiDev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywikidev/2a07c12d-8c31-4004-9755-06a2d6ba2d5eo%40googlegroups.com.
