This will be short, juggling a few other things.

No stress, I know its hard to work through wikitext coding. For all its 
strengths it can be hard to follow.
Not using a version control like git also makes this harder, we both can't 
see exactly what the other person has changed.

$:/core/ui/EditTemplate/body/editor

You untagged it or just copied the changes. Remember, the edit widget in 
that tiddlers triggers actions, that invoke a popup with action-popupcaret. 
The reveal widget for the popup is inside the edit widget, as we previously 
discussed. 

If you keep in mind the flow between the different components that I 
explained earlier in this thread, I think the next steps in this 
development work will be a lot easier.

edit widget -> user types -> actions -> action-popupcaret -> reveal widget 
shows your popup tiddler.

On Sunday, July 12, 2020 at 6:02:50 PM UTC+2, Mat wrote:
>
> Sorry for confusion. I did write that "Having now tried it I'm finding it 
> is not an issue." so I only asked out of curiosity and I now understand 
> that the replace code doesn't bother with the trigger-end, which is what I 
> misunderstood.
>
> [...] I have my fingers in too many pies already and releasing plugins 
>> comes with a maintenance commitment.
>> The intention behind the demos I share is to hopefully inspire/provide 
>> ideas and techniques for others to follow.
>>
>
> Fair enuff and your contributions and demos are appreciated!
>  
>
>> [...] the popup *loses focus* as soon as the selectwidget or editor is 
>>> touched. Any ideas for this?
>>>
>> [...] give it the class tc-popup-keep.
>>
>
> Thanks. I find no mention of RevealWidget (i.e reveal) in the tiddlers 
> tagged $:/EditorMagic, Maybe it is invoked in 
> $:/plugins/EditorMagic/reveal-widget-tweak which I dare not touch - ?
>
>
> Note that  the ??tr present at the beginning of the tiddler adds a 
>> transclusion portion to every other popup created. This seems to not be an 
>> issue with an incomplete link or widget, but with ??tr so perhaps its 
>> limited to those with no end-trigger? 
>>
>
> Interestingly (and luckily), it seems to be the other way around: I had 
> mistakely kept a faux trigger-end in the tool for ??tr (i.e 
> EditorMagic/TransINclude) and have now removed it, which also removed the 
> undesired popup content.
>
> [your image with the artefact]
>>
> This is related to the next issue you bring up.
>  
>
>> Looks like you missed some bits when integrating my code from 
>> https://saqimtiaz.github.io/sq-tw/editormagic-popup.html#EditorMagic%2F_Popup
>>
>> <$list filter="""[<text>search<trigger>removeprefix<before>]
>>     +[!prefix[ ]splitregexp<triggexp>]
>>     +[!search::regexp<triggendexp>]
>>     +[last[]]""">
>>  <$set name=fragment filter="""[<currentTiddler>]""" select="0">
>>  <$list filter="[<fragment>minlength[1]]">
>>  <$list filter="[all[tiddlers]prefix<fragment>count[]!match[0]]" 
>> variable="_NULL">
>>  <div style="background:white; border:1px solid silver; padding:0 5px;">
>>
>>
> The thing is, not every tool requires a minlength of one. The TitlePicker 
> does because there are so many titles, but it would be a mistake to demand 
> it for e.g widgets or macros where you might not have any idea what the 
> initial letter is until you see it. So I moved the yellow text into the 
> TitlePicker. Not to mention triggers like ??tr that don't have a fragment 
> (the trigger is those four characters).
>
> Apropos the arteface in the image you posted: This is caused from the code 
> below the yellow, specifically the border which I've now changed to be an 
> outline with an outline-offset:-1px to solve it.
>
> There are some changes I think we need to make next, to the order of the 
>> wikitext code that controls triggering the popup. However, I will wait for 
>> you to work out the issues discussed in this post and properly integrate my 
>> previous changes before I get into that.
>>
>
> Terrific. I've updated according to my comments - which means 
> tc-popup-keep has not been resolved and the yellow is not re-introduced but 
> still found in TitlePicker.  By the way, I'm sorry if I seem very slow in 
> everything but every little thing takes a lot of looking up and testing 
> etc. Just replying to this took over an hour. *I don't mind that*, it is 
> very constructive and your help is super valuable, I'm just a little 
> stressed that you might think I'm not doing anything.
>
> Again, thank you!
>
> <:-)
>

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/a71a0262-59aa-4c7c-a41a-efe292f1447bo%40googlegroups.com.

Reply via email to